Repository navigation
compiletest: Panic in ProcOutput::extend #98469
Description
in #96551 the logic for deciding when to filter paths was changed in compiletest such that known paths are always considered to be 32 bytes long.
Unfortunately this logic has an error in the case where the known path is shorter than 32 bytes, as the logic may decide to abbreviate the output due to it exceeding HEAD_LEN + TAIL_LEN bytes in length, however the output isn't long enough, so the following check underflows, leading to a panic in split_off:
rust/src/tools/compiletest/src/read2.rs
Line 92 in 6609c67
Activity
jieyouxu commentedon Oct 17, 2024
compiletest triage:
rust/src/tools/compiletest/src/read2.rs
Line 87 in 798fb83
seems to have a proper
saturing_subnow, probably fixed by #96551. The logic here isn't exactly pretty, however.