Skip to content

Bootstrap: Initialized submodules no longer eagerly updated by running x.py #99083

Closed
#100008
Closed
Bootstrap: Initialized submodules no longer eagerly updated by running x.py#99083
#100008
Assignees
jyn514
Labels
C-bugCategory: This is a bug.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Description

@bjorn3
bjorn3
opened on Jul 9, 2022

maybe_update_submodules should already do this, but

rust/src/bootstrap/lib.rs

Lines 628 to 635 in c4693bc

let mut bootstrap_submodules: Vec<&str> = vec![
"src/tools/rust-installer",
"src/tools/cargo",
"src/tools/rls",
"src/tools/miri",
"library/backtrace",
"library/stdarch",
];
hasn't been kept in sync with the removal of identical functionality from x.py. Also rust-analyzer is only updated when vendoring is enabled.

Activity

  1. bjorn3
    added
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    C-bugCategory: This is a bug.
    on Jul 9, 2022
  2. bjorn3
    assigned
    jyn514
    on Jul 9, 2022

  3. matthiaskrgr commented on Jul 9, 2022

    @matthiaskrgr
    matthiaskrgr
    on Jul 9, 2022
    Member

    I think this was caused by #97513

  4. jyn514
    added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    on Jul 9, 2022
  5. jyn514
    added a commit that references this issue on Aug 1, 2022

    Update all pre-cloned submodules on startup

    f2164c3
  6. matthiaskrgr
    added a commit that references this issue on Aug 2, 2022

    Rollup merge of rust-lang#100008 - jyn514:eager-submodules, r=bjorn3

    4fbe53f
  7. bors
    closed this as completedin f2164c3on Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

C-bugCategory: This is a bug.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions