Skip to content

Move stdlib tests from src/test/ui-fulldeps to library/std/tests #99417

Description

@ChrisDenton

I think std tests should ideally live in the library/std directory but today we have a few that are in src/test/ui-fulldeps.

Tests I think could be moved:

Activity

  1. jyn514 commented on Apr 9, 2023

    @jyn514
    Member

    Looks like create-dir-all-bare and rename-directory were changed to an integration test in #108233.

    The rest of these are moving from ui-fulldeps to ui in #109875, but it would still be nice to get them out of tests/ui altogether so they don't require building the compiler.

  2. added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    C-enhancementCategory: An issue proposing an enhancement or a PR with one.
    A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to Rust
    T-libsRelevant to the library team, which will review and decide on the PR/issue.
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    on Apr 9, 2023
  3. 766974616c79 commented on Jun 3, 2023

    @766974616c79
    Contributor

    Hi, is this no longer an issue?

  4. jyn514 commented on Jun 3, 2023

    @jyn514
    Member

    this is still an issue.

    ; ls tests/ui/std
    issue-15149.rs  issue-81357-unsound-file-methods.rs  stdio-from.rs  switch-stdout.rs
    
  5. 766974616c79 commented on Jun 3, 2023

    @766974616c79
    Contributor

    issue-81357-unsound-file-methods.rs

    OK, is the issue-81357-unsound-file-methods.rs file also included? I'll try to resolve this issue

  6. 766974616c79 commented on Jun 3, 2023

    @766974616c79
    Contributor

    @rustbot claim

  7. 766974616c79 commented on Jun 4, 2023

    @766974616c79
    Contributor

    Hi, I managed to move the switch-stdout.rs file but I have a problem with the stdio-from.rs file, I can't see how to use Stdio without going through the command system? Am I right?

  8. 6 remaining items

  9. Dylan-DPC commented on Aug 24, 2023

    @Dylan-DPC
    Member

    @MoskalykA sorry for the delayed response but are you still interested in the other tests that are missing?

  10. 766974616c79 commented on Aug 24, 2023

    @766974616c79
    Contributor

    sorry for the delayed response but are you still interested in the other tests that are missing?

    Yes, as suggested by petrochenkov, tests from the tests\ui\stdlib-unit-tests folder should be moved. But would library/std/tests as destination be correct?

  11. DanielFrantes commented on Jan 1, 2024

    @DanielFrantes

    I can look on it but i need to know what am i supposed to do.

  12. DanielFrantes commented on Jan 5, 2024

    @DanielFrantes

    @rustbot claim

  13. DanielFrantes commented on Jan 7, 2024

    @DanielFrantes
  14. rustbot commented on Jan 7, 2024

    @rustbot
  15. added a commit that references this issue on May 6, 2024
  16. BansalShivanshu commented on Nov 26, 2024

    @BansalShivanshu

    Is this issue fully complete? what's remaining? I would love to take over in prompt time!

  17. jieyouxu commented on Nov 27, 2024

    @jieyouxu
    Member

    Is this issue fully complete? what's remaining? I would love to take over in prompt time!

    This is probably what needs investigating at the moment, i.e. the current status of this issue.

  18. added
    E-needs-investigationCall for participation: This issues needs some investigation to determine current status
    on Nov 27, 2024
  19. ChrisDenton commented on Nov 28, 2024

    @ChrisDenton
    MemberAuthor

    Sorry I've not been keeping up with the issue.

    I have now checked and it seems there are no longer any std tests in the ui-fulldeps directory so I'm closing this as complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustA-testsuiteArea: The testsuite used to check the correctness of rustcC-enhancementCategory: An issue proposing an enhancement or a PR with one.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.E-needs-investigationCall for participation: This issues needs some investigation to determine current statusT-libsRelevant to the library team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions