Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
Uh oh!
There was an error while loading.
Please reload this page
.
rust-lang
/
rust
Public
Uh oh!
There was an error while loading.
Please reload this page
.
Notifications
You must be signed in to change notification settings
Fork
15.5k
Star
117k
Code
Issues
5k+
Pull requests
1.4k
Actions
Projects
Security and quality
6
Insights
Additional navigation options
Code
Issues
Pull requests
Actions
Projects
Security and quality
Insights
Various impl trait in assoc tys cleanups
- #112891
#112891
Merged
bors
merged 13 commits into
rust-lang:master
rust-lang/rust:master
from
oli-obk:impl_trait_in_assoc_tys_cleanup
oli-obk/rust:impl_trait_in_assoc_tys_cleanup
Copy head branch name to clipboard
Jun 24, 2023
Conversation
Commits
13
(13)
Checks
Files changed
Merged
Various impl trait in assoc tys cleanups
#112891
bors
merged 13 commits into
rust-lang:master
rust-lang/rust:master
from
oli-obk:impl_trait_in_assoc_tys_cleanup
oli-obk/rust:impl_trait_in_assoc_tys_cleanup
Copy head branch name to clipboard
Commits
Commits on Jun 22, 2023
Move `opaque_type_origin_unchecked` onto `TyCtxt` and re-use it where it was open coded
oli-obk
committed
c8979e5
View commit details
Copy full SHA for c8979e5
Browse repository at this point
Only create the opaque collector once and visit it many times
oli-obk
committed
bae6454
View commit details
Copy full SHA for bae6454
Browse repository at this point
Point to argument/return type instead of the whole function header
oli-obk
committed
12243ec
View commit details
Copy full SHA for 12243ec
Browse repository at this point
Add tests showcasing our short circuiting behaviour in the signature checks for defining scopes
oli-obk
committed
326a9fa
View commit details
Copy full SHA for 326a9fa
Browse repository at this point
Stop failing eagerly, and collect all opaque types even if some are erroneous.
oli-obk
committed
41881ae
View commit details
Copy full SHA for 41881ae
Browse repository at this point
Treat opaque types failing the signature defining scope check as defining, as we already errored and can hide subsequent errors this way.
oli-obk
committed
a71628c
View commit details
Copy full SHA for a71628c
Browse repository at this point
Fix a codegen test
oli-obk
committed
d6e1b20
View commit details
Copy full SHA for d6e1b20
Browse repository at this point
Re-use error code for duplicate error
oli-obk
committed
30ff127
View commit details
Copy full SHA for 30ff127
Browse repository at this point
Move some field extraction logic onto a method on `Node`
oli-obk
committed
cb161e7
View commit details
Copy full SHA for cb161e7
Browse repository at this point
Document what is going on in `opaque_types_defined_by`
oli-obk
committed
0af4a21
View commit details
Copy full SHA for 0af4a21
Browse repository at this point
ICE on types that should not be defining opaque types
oli-obk
committed
b0b4a07
View commit details
Copy full SHA for b0b4a07
Browse repository at this point
Handle weak type aliases by immediately resolving them to their aliased type
oli-obk
committed
b323f58
View commit details
Copy full SHA for b323f58
Browse repository at this point
Only walk the identity substituted version of struct fields
oli-obk
committed
27b386a
View commit details
Copy full SHA for 27b386a
Browse repository at this point
You can’t perform that action at this time.