-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
Preserve ambiguous glob lint for subtrait method picks #157968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rust-bors
merged 1 commit into
rust-lang:main
from
kevin-valerio:fix/issue-157965-ambiguous-glob-subtrait
Aug 30, 2026
+57
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
tests/ui/supertrait-shadowing/ambiguous-glob-imported-subtrait.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| // issue: <https://github.com/rust-lang/rust/issues/157965> | ||
|
|
||
| #![feature(supertrait_item_shadowing)] | ||
| #![deny(ambiguous_glob_imported_traits)] | ||
|
kevin-valerio marked this conversation as resolved.
|
||
|
|
||
| trait DefaultPolicy { | ||
| fn allow_action(&self) -> bool { | ||
| false | ||
| } | ||
| } | ||
|
|
||
| mod first_policy { | ||
| pub trait Role: crate::DefaultPolicy { | ||
| fn allow_action(&self) -> bool { | ||
| true | ||
| } | ||
| } | ||
|
|
||
| impl crate::DefaultPolicy for u8 {} | ||
| impl Role for u8 {} | ||
| } | ||
|
|
||
| mod second_policy { | ||
| pub trait Role: crate::DefaultPolicy { | ||
| fn audit_only(&self) {} | ||
| } | ||
| } | ||
|
|
||
| use first_policy::*; | ||
| use second_policy::*; | ||
|
|
||
| fn main() { | ||
| assert!(0u8.allow_action()); | ||
| //~^ ERROR Use of ambiguously glob imported trait `Role` | ||
| //~| WARN this was previously accepted by the compiler but is being phased out | ||
| } | ||
20 changes: 20 additions & 0 deletions
20
tests/ui/supertrait-shadowing/ambiguous-glob-imported-subtrait.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| error: Use of ambiguously glob imported trait `Role` | ||
| --> $DIR/ambiguous-glob-imported-subtrait.rs:33:17 | ||
| | | ||
| LL | use first_policy::*; | ||
| | ------------ `Role` imported ambiguously here | ||
| ... | ||
| LL | assert!(0u8.allow_action()); | ||
| | ^^^^^^^^^^^^ | ||
| | | ||
| = help: Import `Role` explicitly | ||
| = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! | ||
| = note: for more information, see issue #152822 <https://github.com/rust-lang/rust/issues/152822> | ||
| note: the lint level is defined here | ||
| --> $DIR/ambiguous-glob-imported-subtrait.rs:4:9 | ||
| | | ||
| LL | #![deny(ambiguous_glob_imported_traits)] | ||
| | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| error: aborting due to 1 previous error | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.