Skip to content

Quote version script symbols #158607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syrel wants to merge 2 commits into
base: main
Choose a base branch
from
+25 −2
Open

Quote version script symbols #158607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11548b7
Export quoted symbols in a version script
syrel Jun 30, 2026
6f7a111
Extend double quoted symbols test with an assertion
syrel Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/rustc_codegen_ssa/src/back/linker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,8 +872,8 @@ impl<'a> Linker for GccLinker<'a> {
if !symbols.is_empty() {
writeln!(f, " global:")?;
for sym in symbols {
debug!(" {};", sym.name);
writeln!(f, " {};", sym.name)?;
debug!(" \"{}\";", sym.name);
writeln!(f, " \"{}\";", sym.name)?;
}
}
writeln!(f, "\n local:\n *;\n}};")?;
Expand Down
4 changes: 4 additions & 0 deletions tests/run-make/export-quoted-symbols-version-script/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#![crate_type = "cdylib"]

#[unsafe(export_name = "some$foo::bar$thing/path.rs:42")]
pub extern "C" fn exported_symbol_with_version_script_special_characters() {}

@bjorn3 bjorn3 Aug 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a function with bad_∢ as symbol name as test for #38238? It is possible that a linker does support arbitrary printable ascii characters, but not unicode characters.

19 changes: 19 additions & 0 deletions tests/run-make/export-quoted-symbols-version-script/rmake.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
//@ only-linux
//@ needs-crate-type: cdylib

extern crate run_make_support;

use run_make_support::object::Object;
use run_make_support::{dynamic_lib_name, object, rfs, rustc};

const EXPORTED_SYMBOL: &[u8] = b"some$foo::bar$thing/path.rs:42";

fn main() {
rustc().input("lib.rs").run();

let contents = rfs::read(dynamic_lib_name("lib"));
let object = object::File::parse(contents.as_slice()).unwrap();
let matching_exports =
object.exports().unwrap().iter().filter(|x| x.name() == EXPORTED_SYMBOL).count();

@bjorn3 bjorn3 Aug 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Instead of .filter().count() this could also be .any(). No need to assert there is exactly one symbol with this name. There can't be multiple exported symbols with the same name anyway.

assert_eq!(matching_exports, 1);
}
Loading