Skip to content

riscv: stabilize 'd' and 'f' target features #161385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RalfJung wants to merge 3 commits into
base: main
Choose a base branch
from
Open

riscv: stabilize 'd' and 'f' target features #161385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
265a608
Reapply "riscv: promote d, e, and f target_features to CfgStableToggl…
RalfJung Aug 20, 2026
55c68a8
do not stabilize 'e'
RalfJung Aug 20, 2026
dc66d14
fully stabilize d, f
RalfJung Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions compiler/rustc_target/src/target_features.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,9 +680,9 @@ static RISCV_FEATURES: &[(&str, Stability, ImpliedFeatures)] = &[
("a", Stable, &["zaamo", "zalrsc"]),
("b", Stable, &["zba", "zbb", "zbs"]),
("c", Stable, &["zca"]),
("d", Unstable(sym::riscv_target_feature), &["f"]),
("e", Unstable(sym::riscv_target_feature), &[]),
("f", Unstable(sym::riscv_target_feature), &["zicsr"]),
("d", Stable, &["f"]),
("e", Unstable(sym::riscv_target_feature), &[]), // negative feature! needs special care.
("f", Stable, &["zicsr"]),
(
"forced-atomics",
// Not implied by any CPU model or other feature.
Expand Down
8 changes: 1 addition & 7 deletions tests/ui/target-feature/abi-incompatible-target-feature-flag-enable.riscv.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
warning: unstable feature specified for `-Ctarget-feature`: `d`
|
= note: this feature is not stably supported; its behavior can change in the future
= note: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #162235 <https://github.com/rust-lang/rust/issues/162235>

warning: target feature `d` must be disabled to ensure that the ABI of the current target can be implemented correctly
|
= note: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #162235 <https://github.com/rust-lang/rust/issues/162235>

warning: 2 warnings emitted
warning: 1 warning emitted

1 change: 0 additions & 1 deletion tests/ui/target-feature/abi-incompatible-target-feature-flag-enable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,4 @@ extern crate minicore;
use minicore::*;

//~? WARN must be disabled to ensure that the ABI of the current target can be implemented correctly
//[riscv]~? WARN unstable feature specified for `-Ctarget-feature`
//[x86]~? WARN use a soft-float target instead
8 changes: 1 addition & 7 deletions tests/ui/target-feature/abi-required-target-feature-flag-disable.riscv.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
warning: unstable feature specified for `-Ctarget-feature`: `d`
|
= note: this feature is not stably supported; its behavior can change in the future
= note: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #162235 <https://github.com/rust-lang/rust/issues/162235>

warning: target feature `d` must be enabled to ensure that the ABI of the current target can be implemented correctly
|
= note: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #162235 <https://github.com/rust-lang/rust/issues/162235>

warning: 2 warnings emitted
warning: 1 warning emitted

2 changes: 1 addition & 1 deletion tests/ui/target-feature/abi-required-target-feature-flag-disable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,4 @@ extern crate minicore;
use minicore::*;

//~? WARN must be enabled to ensure that the ABI of the current target can be implemented correctly
//[x86,riscv]~? WARN unstable feature specified for `-Ctarget-feature`
//[x86]~? WARN unstable feature specified for `-Ctarget-feature`
Loading