Skip to content

Do not load macro metadata for local definitions in rustdoc - #161877

Open
qaijuang wants to merge 2 commits into
rust-lang:mainfrom
qaijuang:156009-follow-up
Open

Do not load macro metadata for local definitions in rustdoc#161877
qaijuang wants to merge 2 commits into
rust-lang:mainfrom
qaijuang:156009-follow-up

Conversation

@qaijuang

@qaijuang qaijuang commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Follow up fix to #156009.

Closes #161837

r? @GuillaumeGomez

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 27, 2026
//! [queue]
//~^ ERROR redundant explicit link target

#[macro_export]

@GuillaumeGomez GuillaumeGomez Aug 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe create a new test instead? Would make this one smaller and easier to track too. ;)

View changes since the review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@qaijuang
qaijuang marked this pull request as ready for review August 27, 2026 16:58
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 27, 2026
@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup

@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0f08915 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 28, 2026
…aumeGomez

Do not load macro metadata for local definitions in rustdoc

Follow up fix to rust-lang#156009.

Closes rust-lang#161837

r? @GuillaumeGomez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: Failed to get crate data for crate0 when documenting crossterm

3 participants