Skip to content

Rollup of 11 pull requests - #162148

Merged
rust-bors[bot] merged 28 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-Be980n8
Sep 1, 2026
Merged

Rollup of 11 pull requests#162148
rust-bors[bot] merged 28 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-Be980n8

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

hanna-kruppe and others added 28 commits August 29, 2026 13:50
I added this flag back in 2017 to enable benchmarking of the saturating
semantics when it was newly implemented and still experimental. But
saturation has been the official semantics for float<->int `as` casts
for years now. A flag for turning it off no longer serves any purpose,
it's just `-Zplease-miscompile-casts` now.
tests/ui/match/match-stack-overflow-72933-.rs crashes on s390x due to
hitting stack_size limit. changing the size to 17MB  the crash.
Reduce the scope of `unsafe` blocks that are not yet documented by moving safe
operations out of the blocks, making it easier to add the missing documentation
in the future.
rustdoc: add `--print` option

Context: `--print crate-root-lint-levels` (rust-lang#139180) is only available for `rustc` and `clippy-driver`, while it would make sense for it to also be available for `rustdoc` (à la rust-lang#83895.)

Not too sure about the stability of `rustdoc --print=any` or if this needs a MCP; strictly speaking, only `rustdoc +nightly -Z unstable-options --print=crate-root-lint-levels` would be required (and the `rustdoc --print` would be stabilized together with `crate-root-lint-levels`), but I guess that makes sense to have all the `--print`s for consistency.

For regression tests, not sure if ui or run-make is preferable, as run-make would need some sort of trait to avoid duplicating code between `rustc()` and `rustdoc()` (or just test `rustdoc` as it delegates to `rustc`):
https://github.com/rust-lang/rust/blob/021fc25b7a48f6051bee1e1f06c7a277e4de1cc9/tests/run-make/print-crate-root-lint-levels/rmake.rs#L82-L88

@rustbot label +A-CLI +A-print-requests
Update `icu_list` dependency to 2.3

This removes the `icu_collections` transitive dependency, and uses the smaller `icu_locale_fallback` instead of `icu_locale`.

r? manishearth
…isDenton

change DEFAULT_STACK_SIZE to be 32MB on s390x

`tests/ui/match/match-stack-overflow-72933-.rs` crashes on s390x due to hitting stack_size limit(rust-lang#161742).
changing the size to 32MB on s390x fixes the crash.
Diverse offload fixes

`HostMetadata` pass skips linking. Now, `offload_kernel` macro lowers to `core` instead of `std`.

closes: rust-lang#161703

r? @ZuseZ4
…RalfJung

Remove -Zsaturating-float-casts flag

I added this flag back in 2017 (rust-lang#45205) to enable benchmarking of the saturating semantics when it was newly implemented and still experimental. But saturation has been the official semantics for float<->int `as` casts for years now. A flag for turning it off no longer serves any purpose, it's just `-Zplease-miscompile-casts` now.
…t-mismatch-ice, r=estebank

Fix ICE of getting item name from RPITIT

Fixes rust-lang#161915

RPITIT projections use anonymous associated type and have no item name.
Rework `next_power_of_two` to always be `1 << …`

r? @clarfonthey
Who accidentally nerd-sniped me by mentioning rust-lang#161069

This obviates that PR by reworking the `(checked_)next_power_of_two` logic to calculate the necessary exponent e, then return 2ᵉ, so it's structurally obvious from the IR -- the `shl nuw 1, …` instruction -- that it's always a power of two.

As always, the reason this is tricky is because shifts don't work for `<< Self::BITS`.  The previous code handled that by checking `self <= 1` first, and thus doing a `-1 >> n` where `n < BITS`.  This code instead flips the check: it looks up-front for a value that will wrap (an input above `1 << (BITS - 1)`) and thus by excluding those cases the calculated `1 << n` always has `n < BITS`.  And the codegen tests show that, without needing any `llvm.assume`s, LLVM can take advantage of it to do things like rewriting `%` to masking.  Plus the overflow check optimizes out for constrained inputs like slice lengths.
…nthey

Change some `Infallible` to `!` in std

I believe this desirable since we recommend `!` over `Infallible`, so std follows its own advice. Most changes are to unstable features, but not all. Similar changes in compiler have to wait for a bootstrap update.
… r=mejrs

Remove `gate_check` from `AttributeStability::Unstable`

Based on the idea from rust-lang#162051 (comment)

r? @mejrs
…oc, r=clarfonthey

`alloc` crate: shrink undocumented `unsafe` blocks

Reduce the scope of `unsafe` blocks that are not yet documented by moving safe operations out of the blocks, making it easier to add the missing documentation in the future.
make it clear that Range cannot represent arbitrary ranges

This seems like a useful clarification, though it is already heavily implied by the first sentence in the docs.

What is less clear to me is what type one *should* use to represent arbitrary ranges. Should we recommend `(Bound<T>, Bound<T>)` for that purpose? It seems best-stuied, and is already used for that purpose by the btree collections and in rust-lang#136903. However, I suspect it is also common that one wants to represent an arbitrary range that's bounded on both sides. `RangeInclusive` can represent all those (though representing the empty range is a bit awkward), `Range` cannot.

Nominating for t-libs to get their general vibe on what we want to recommend here, if anything.
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Sep 1, 2026
@rustbot rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Sep 1, 2026
@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 1, 2026
Rollup of 11 pull requests


try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple-1
try-job: aarch64-apple-2
try-job: x86_64-mingw-1
try-job: i686-msvc-1
try-job: i686-msvc-2
@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 9c23ab9 (9c23ab94617f52305568768bed5250c5dc707b2a)
Base parent: a433023 (a4330234a776684c36428d001721d0320d24dd77)

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 1, 2026
@rust-bors

rust-bors Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 6m 36s
Pushing 5db7f4b to main...

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a433023 (parent) -> 5db7f4b (this PR)

Test differences

Show 1131 test diffs

Stage 1

  • [codegen] tests/codegen-llvm/lib-optimizations/next_power_of_two.rs#x86_64: [missing] -> pass (J1)
  • [run-make] tests/run-make/offload-generic-manifest: ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) -> [missing] (J1)
  • [run-make] tests/run-make/offload/generic-manifest: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J1)
  • [run-make] tests/run-make/offload/host-std-device-nostd: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J1)
  • [run-make] tests/run-make/rustdoc/doctest/markdown: [missing] -> pass (J1)
  • [run-make] tests/run-make/rustdoc/print-crate-root-lint-levels: [missing] -> pass (J1)
  • [run-make] tests/run-make/rustdoc/print-request-help: [missing] -> pass (J1)
  • [codegen] tests/codegen-llvm/lib-optimizations/next_power_of_two.rs#x86_64: [missing] -> ignore (only executed when the architecture is x86_64) (J2)
  • [codegen] tests/codegen-llvm/lib-optimizations/next_power_of_two.rs#aarch64: [missing] -> ignore (only executed when the architecture is aarch64) (J8)
  • [ui] tests/ui/impl-trait/in-trait/rpitit-mismatch-missing-item-name-issue-161915.rs: [missing] -> pass (J9)
  • [ui (polonius)] tests/ui/impl-trait/in-trait/rpitit-mismatch-missing-item-name-issue-161915.rs: [missing] -> pass (J12)

Stage 2

  • [run-make] tests/run-make/offload-generic-manifest: ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) -> [missing] (J0)
  • [run-make] tests/run-make/offload/generic-manifest: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J0)
  • [run-make] tests/run-make/offload/host-std-device-nostd: [missing] -> ignore (ignored when LLVM Offload is disabled or LLVM is not the default codegen backend) (J0)
  • [run-make] tests/run-make/rustdoc/print-crate-root-lint-levels: [missing] -> pass (J0)
  • [run-make] tests/run-make/rustdoc/print-request-help: [missing] -> pass (J0)
  • [codegen] tests/codegen-llvm/lib-optimizations/next_power_of_two.rs#aarch64: [missing] -> ignore (only executed when the architecture is aarch64) (J3)
  • [codegen] tests/codegen-llvm/lib-optimizations/next_power_of_two.rs#x86_64: [missing] -> ignore (only executed when the architecture is x86_64) (J4)
  • [run-make] tests/run-make/rustdoc/doctest/markdown: [missing] -> ignore (ignored when running tests remotely ((e.g. armhf-gnu))) (J5)
  • [run-make] tests/run-make/rustdoc/doctest/markdown: [missing] -> pass (J6)
  • [ui] tests/ui/impl-trait/in-trait/rpitit-mismatch-missing-item-name-issue-161915.rs: [missing] -> pass (J7)
  • [codegen] tests/codegen-llvm/lib-optimizations/next_power_of_two.rs#aarch64: [missing] -> pass (J10)
  • [codegen] tests/codegen-llvm/lib-optimizations/next_power_of_two.rs#x86_64: [missing] -> pass (J11)

Additionally, 1108 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 5db7f4be8a36c1b8ae19299469e2be2b0f052c21 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-miri: 59m 51s -> 1h 30m (+50.5%)
  2. x86_64-gnu-nopt: 1h 38m -> 2h 27m (+50.1%)
  3. x86_64-gnu-debug: 2h 6m -> 1h 16m (-39.6%)
  4. dist-powerpc-linux: 1h 12m -> 1h 35m (+31.7%)
  5. dist-android: 25m 57s -> 33m 22s (+28.6%)
  6. dist-powerpc64-linux-musl: 1h 19m -> 1h 41m (+28.4%)
  7. x86_64-gnu-llvm-22-2: 1h 24m -> 1h 48m (+27.7%)
  8. x86_64-gnu-llvm-21: 45m 5s -> 55m 2s (+22.1%)
  9. dist-x86_64-illumos: 1h 33m -> 1h 53m (+20.7%)
  10. dist-x86_64-mingw: 2h 42m -> 2h 9m (-20.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (5db7f4b): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.1% [0.1%, 0.1%] 1
Regressions ❌
(secondary)
0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.3% [-0.3%, -0.3%] 1
All ❌✅ (primary) 0.1% [0.1%, 0.1%] 1

Max RSS (memory usage)

Results (secondary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) - - 0

Cycles

Results (secondary -5.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.5% [-5.5%, -5.5%] 1
All ❌✅ (primary) - - 0

Binary size

Results (primary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.2% [0.0%, 0.3%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.2% [-0.2%, -0.2%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [-0.2%, 0.3%] 3

Bootstrap: 473.301s -> 475.082s (0.38%)
Artifact size: 400.69 MiB -> 400.59 MiB (-0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-run-make Area: port run-make Makefiles to rmake.rs A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-search Area: Rustdoc's search feature A-tidy Area: The tidy tool A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.