Repository navigation
Add unsafe attributes and impls to tidy unsafety check - #163781
Draft
clarfonthey wants to merge 2 commits into
Draft
clarfonthey wants to merge 2 commits into
clarfonthey wants to merge 2 commits into
Conversation
rustbot
added
A-tidy
clarfonthey
force-pushed
the
tidy-unsafe
branch
4 times, most recently
from
October 5, 2026 03:12
54bf656 to
76cddd9
Compare
clarfonthey
commented
Oct 5, 2026
clarfonthey
force-pushed
the
tidy-unsafe
branch
7 times, most recently
from
October 5, 2026 03:42
217f6d0 to
6ff92ca
Compare
teor2345
reviewed
Oct 5, 2026
clarfonthey
force-pushed
the
tidy-unsafe
branch
from
October 5, 2026 15:49
6ff92ca to
d1865fc
Compare
Collaborator
|
|
clarfonthey
force-pushed
the
tidy-unsafe
branch
from
October 6, 2026 14:51
d1865fc to
4ddc8cf
Compare
clarfonthey
commented
Oct 6, 2026
nia-e
reviewed
Oct 6, 2026
clarfonthey
force-pushed
the
tidy-unsafe
branch
from
October 7, 2026 20:26
4ddc8cf to
bc54a4b
Compare
nia-e
reviewed
Oct 7, 2026
| impl<T, const N: usize, A: Allocator> FusedIterator for BoxedArrayIntoIter<T, N, A> {} | ||
|
|
||
| #[stable(feature = "boxed_array_value_iter", since = "1.99.0")] | ||
| // SAFETY: We just forward to `vec::IntoIter`, which has a trustable length. |
Member
There was a problem hiding this comment.
We actually just take the raw length of the array here (see library/alloc/src/boxed/iter.rs:254)
|
|
||
| #[doc(hidden)] | ||
| #[unstable(issue = "none", feature = "trusted_fused")] | ||
| // SAFETY: We just forward to `vec::IntoIter`, which is always fused. |
Member
There was a problem hiding this comment.
The only safety req on the trait is that the impl isn't lifetime-dependent (library/core/src/iter/traits/marker.rs:8)
| } | ||
|
|
||
| #[cfg(not(test))] | ||
| // SAFETY: We don't mutate the contained data when returning it. |
Member
There was a problem hiding this comment.
The trait bounds here are kinda underspecified but I read the safety req (library/alloc/src/vec/in_place_collect.rs:428) as being something like "The internals of IntoIter promise never to mutate the data or create a reference to the entire allocation"
Contributor
|
☔ The latest upstream changes (presumably #164187) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another big one.
r? nia-e