Repository navigation
std: add doctest to parent_id - #164151
Conversation
|
r? @clarfonthey rustbot has assigned @clarfonthey. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
@rustbot reroll |
|
@bors r+ rollup |
…plett std: add doctest to parent_id This operation is currently entirely untested. (I know because it shows up nowhere in the test failures when running the test suite in Miri, and Miri does not support this operation.) So let's add a test.
Rollup of 6 pull requests Successful merges: - #160597 (bootstrap: always build llvm's dylib when linking to it) - #162810 (vectorized vec::dedup pre-scan) - #162931 (directly deallocates the nodes instead of traversing every element when BTreemap dropping) - #162027 (std: add `fs::rename_noreplace`) - #164146 (Nuke `Unique` (and `ptr_internals`)) - #164151 (std: add doctest to parent_id)
|
|
This pull request was unapproved. This PR was contained in a rollup (#164179), which was unapproved. |
|
How is that possible...? The doctest should only exist if we have the unix target feature? |
|
Apparently this was on aarch64-pc-windows-msvc. The entire file should be completely ignored there, no? Seems like all the other doctests in #[cfg_attr(target_family = "unix", doc = "```")]
#[cfg_attr(not(target_family = "unix"), doc = "```ignore (needs unix)")]It makes no sense at all to me that this should be needed. |
5fd1cb6 to
0103672
Compare
|
@bors r=joshtriplett |
…uwer Rollup of 6 pull requests Successful merges: - #163824 (aarch64: Use neon registers for ABI on targets that require `neon") - #162257 (Revise the VEXos synchronization model) - #163832 (reject non-async coroutine closures as async callables) - #163990 (`AliasConstKind`: add intra-doc links to `AliasTyKind`) - #164031 (Adding File Lock Support for Haiku) - #164151 (std: add doctest to parent_id)
Rollup merge of #164151 - RalfJung:parent_id_test, r=joshtriplett std: add doctest to parent_id This operation is currently entirely untested. (I know because it shows up nowhere in the test failures when running the test suite in Miri, and Miri does not support this operation.) So let's add a test.
@RalfJung This incantation is the correct one. See #162112 (comment) |
This operation is currently entirely untested. (I know because it shows up nowhere in the test failures when running the test suite in Miri, and Miri does not support this operation.)
So let's add a test.