fix warnings when linkcheck is disabled - #2989
Conversation
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
|
oh, I had forgot about this. This change just hides the error, which is not exactly what I had in mind. I'd like to investigate why linkcheck2 or the linkcheck.sh script return this error. |
|
well, i don’t think it’s an error, it’s a warning. what’s happening is:
this makes sense for mdbook to do, the most likely thing that happened (from its perspective) is that linkcheck crashed. but for our use case, the warning is just noise. |
|
hm, I see. Also, why did you add an additional CI step building without checking links? |
because that's what reproduces this warning. the warning previously only happened when running locally. |
fixes #2808
@apiraino does this fix your problem? i believe those are just warnings and not hard errors, i would expect the output to still show up in
book/html.disclosure: the code and test were generated by an LLM. i wrote the comments.