Split up contributing.md - #2995
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
jyn514
commented
Aug 29, 2026
Member
Author
|
i wonder if (per #775) this needs to be done in combination with new walkthrough sections, rather than in isolation ... i have a draft locally i can push if it's helpful, but unfortunately it does blow up the size of the PR. |
jyn514
force-pushed
the
split-up-contributing-md
branch
from
August 29, 2026 13:28
f721b80 to
17e201e
Compare
Member
Author
|
ok, i shrank this PR instead of growing it, i'll work on further improvements in a separate branch so they don't make this harder to review. |
Member
Author
|
opened #2996 separately, and main...jyn514:rustc-dev-guide:pr-lifecycle building on both. but i tried to keep this PR small. |
reddevilmidzy
approved these changes
Aug 31, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2991. see there for more context.
i highly recommend reviewing this commit-by-commit using
git log --reverse -p --color-moved=dimmed-zebra --color-moved-ws=allow-indentation-change origin/main... Github's diff view is pretty useless here.i kept "Bug reports" in contributing.md because it's linked very widely (including in rust-lang/rust/CONTRIBUTING.md) and i couldn't think of a better place for it. i don't think "Reverting a PR" really belongs in the dev-guide at all except as a link to Forge, but i kept it in contributing.md for now.
i kept the PR lifecycle even though i'm not quite satisfied with it, i think it needs to be handled in combination with improving the "Walkthrough" chapter and i'd rather not make this PR any larger than it is already.
disclosure: i used an LLM for most of this and reviewed its work. i wrote most of the last commit as well as the section titles. i used an LLM to split this into atomic commits, and edited its commit titles.
commits:
r? rustc-dev-guide