fix: typo in thir.md - #3005
Conversation
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
926f32b to
74c8881
Compare
| The implementation of AST lowering is in the [`rustc_ast_lowering`] crate. | ||
| The entry point is [`lower_to_hir`], which retrieves the post-expansion AST | ||
| and resolver data from [`TyCtxt`] and builds the [`hir::Crate`] for the whole crate. | ||
| and resolver data from [`TyCtxt`] and builds the [HIR](../hir.md) for the whole crate. |
There was a problem hiding this comment.
I think this paragraph may need a bit more updating than just replacing the dead hir::Crate link. Since rust-lang/rust#157296, lower_to_hir is no longer a public entry point. Also, after rust-lang/rust#142830, it lowers an individual HIR owner rather than the whole crate.
it might be better to keep only the typo fix in thir.md in this PR and update hir/lowering.md more comprehensively in a separate PR.
There was a problem hiding this comment.
hmh i see, sure i can make the one pr about the typo only and then the future pr for the .md in separate
000wahab000
changed the title
|
so just as u suggested i reverted back the lowering.md changes |
3 participants
Fixes a typo in \src/thir.md.\n\nA more comprehensive update to \src/hir/lowering.md\ (addressing the architectural changes in rust-lang/rust#157296 and rust-lang/rust#142830) will follow in a separate PR.