Add support for frontend threads to the UI - #2568
Open
Kobzol wants to merge 6 commits into
Open
Conversation
…le benchmark parameters in the frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for frontend threads to the UI. Even after many refactorings, adding a new benchmark axis to the frontend still requires a lot of changes :( And there is quite a lot of duplication, particularly in the various used TypeScript types. I did a very minor refactoring while adding frontend threads, but otherwise kept things as-is.
I did not adapt the changes from #2529 in this PR, because I wanted to first get the frontend threads working at all, and then do refactorings separately.
Best reviewed commit-by-commit.
After merging this, we should consider doing some cleanup of the current
-4threadsbenchmarks, because currently they will be shown as having one thread, which doesn't make much sense.