Repository navigation
Add macOS AArch64 support #1248
Description
Activity
I've been looking into this recently. I currently have the full sysroot compiling and passing most of the tests. I've opened a PR for the first set of changes required (supporting the necessary relocations in the object crate). I'm still working on cleaning up the cranelift changes and debugging a few issues before opening PRs.
Reacted by EdorianDark, Afonso Bordado, Muhammad Mominul Huque and Sulaiman Khan GhoriThanks a lot for working on this!
bytecodealliance/wasmtime#5434 has been merged, so tls should work now. Variadic functions like printf will need proper Cranelift support as with the AArch64 macOS ABI variadic arguments are always passed on the stack. The current workaround for missing variadic function support in Cranelift depends on the ABI for variadic arguments being the same as non-variadic arguments, like is the case on most platforms. I will probably also need to hard code support for
objc_msgSendas it can have multiple signatures at the same time depending on the passed in message selector.I just updated the macos_m1_ci branch to test it on cirrus ci. After disabling all debuginfo generation and skipping the tests that use printf (as it is a variadic function), the rest of the tests pass.
Reacted by Rakshith Ravi, Afonso Bordado, Cathal, rami3l, Muhammad Mominul Huque, Adam Szkoda, Daria Sukhonina, DS/Charlie, Yerkebulan Tulibergenov, Malthe Karbo and 3 moreTurns out there is at least one place in libstd where a variadic function is called: https://cirrus-ci.com/task/4835070486249472?logs=test#L116 This can't work until #1451 is fixed. I could make all these calls abort as workaround, but it doesn't sit right with me to announce that arm64 macOS works with that in place.
Edit: Yeah, just tried with an LLVM sysroot and even that will locally codegen the vararg
open()function.Reacted by Mathspy and rami3lI just updated the macos_m1_ci branch to test it on cirrus ci. After disabling all debuginfo generation and skipping the tests that use printf (as it is a variadic function), the rest of the tests pass.
Hey @bjorn3 . If I want to try rustc_codegen_cranelift on macOS AArch64 and cross my fingers nothing is using varargs, what is the best way for me to do this?
Unfortunately even for simple programs the standard library needs to use varargs internally. I tried already.
- added a commit that references this issue
on Jun 21, 2024
CirrusCI now has support for running on M1 macs: https://cirrus-ci.org/guide/macOS/
aarch64-apple-darwin#1500)objc_msgSendto no longer have clashing definitions rust#117910)Branch to run on CirrusCI: https://github.com/bjorn3/rustc_codegen_cranelift/tree/macos_m1_ci