style: use oxfmt as the frontend formatter - #5013
Conversation
rami3l
changed the title
oxfmt as a frontend formatter.oxfmt as the frontend formatter
78bcbba to
6224801
Compare
|
@djc I guess we can merge it now? |
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
| [![Build Status][actions-default-branch]][actions-default-branch-status] | ||
|
|
||
| *Rustup* installs [The Rust Programming Language][rustlang] from the official | ||
| _Rustup_ installs [The Rust Programming Language][rustlang] from the official |
There was a problem hiding this comment.
This is merely a question, not a blocker, but why _ instead if *? Is that an arbitrary choice or is there a reason?
There was a problem hiding this comment.
@ChrisDenton The rationale can be seen here:
underscores have stricter flanking rules (they don't work mid-word like foo_bar_baz), so they're "safer" as the default. prettier's printer source only switches to * when _ would break (adjacent words, nested emphasis, etc.).
I think it's been prettier's style since the first day it supported Markdown (prettier/prettier#2943) and inherited by oxfmt as a drop-in replacement.
4 participants
Closes #4091.
Open Questions
Should we use this for:
TOML files?(To be discussed separately)