Skip to content

chore: inform triagebot of the contribution guidelines - #5027

Merged
rami3l merged 2 commits into
rust-lang:mainfrom
rami3l:chore/contributing-guide-triagebot
Aug 21, 2026
Merged

chore: inform triagebot of the contribution guidelines#5027
rami3l merged 2 commits into
rust-lang:mainfrom
rami3l:chore/contributing-guide-triagebot

Conversation

@rami3l

@rami3l rami3l commented Aug 21, 2026

Copy link
Copy Markdown
Member

As suggested by @Kobzol, this PR tries to make use of the new triagebot features: https://forge.rust-lang.org/triagebot/pr-assignment.html#additional-new-pr-trigger-options

I have decided to remove the pull request template accordingly since it seems to be conveying the same information as the above options here.

@rami3l
rami3l marked this pull request as ready for review August 21, 2026 08:06
@rami3l

rami3l commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

The part of the welcome message regarding the new config introduced here should look like so:

/// Add contribution instructions and/or LLM policy URLs to the given `message`, if configured.
pub fn add_contribution_urls(
    message: &mut String,
    contributing_url: Option<&str>,
    llm_policy: Option<&str>,
) {
    let msg = match (contributing_url, llm_policy) {
        (Some(contrib), Some(llm)) => Some(format!(
            "Please see [the contribution instructions]({contrib}) and our [LLM policy]({llm}) for more information."

https://github.com/rust-lang/triagebot/blob/f1b47efc88b8d9003612b1047f9c70b6269a2cc6/src/handlers/assign/messages.rs#L36-L44

@Kobzol Kobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw I think that keeping the PR template is still good, after all having this information before submitting a PR is better than only having it after the PR is opened.

View changes since this review

Comment thread CONTRIBUTING.md Outdated
Co-authored-by: Jakub Beránek <berykubik@gmail.com>
@rami3l
rami3l force-pushed the chore/contributing-guide-triagebot branch from f46f847 to 3eafc8e Compare August 21, 2026 08:39
@rami3l rami3l changed the title chore: move welcome message for newcomers to triagebot chore: inform triagebot of the contribution guidelines Aug 21, 2026
@rami3l
rami3l force-pushed the chore/contributing-guide-triagebot branch from 3eafc8e to 99b17c4 Compare August 21, 2026 08:42
@rami3l
rami3l added this pull request to the merge queue Aug 21, 2026
Merged via the queue into rust-lang:main with commit 3276a74 Aug 21, 2026
31 checks passed
@rami3l
rami3l deleted the chore/contributing-guide-triagebot branch August 21, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants