docs.rs CDN: set up tracing & configure datadog logging for application logs - #1196
Conversation
|
r? @marcoieni |
84076f5 to
8777861
Compare
c972c1d to
335928c
Compare
335928c to
012409e
Compare
|
Some research showed we're missing some fields:
will improve this and re-request a review, perhaps include the request id. |
d19f168 to
365b492
Compare
|
So, "small" update here. For now I'm using the help of the Generally I would like to extract that stuff into a separate small crate ( |
| "setup-deploy-keys", | ||
| "ansible/roles/dev-desktop/files/team_login", | ||
| ] | ||
| exclude = [ |
There was a problem hiding this comment.
that's because our test-suite now only runs with the fastly test-runner, not as normal tests any more.
There was a problem hiding this comment.
do we need to explicitly exclude the package? If yes, should we also exclude terragrunt/modules/crates-io/compute-static?
There was a problem hiding this comment.
it seems like our package needs to be excluded, but the compute-static one not. didn't dig into why yet.
|
so the main reason for all the code in
|
|
ok, I will apply this now. You can squash your commits if you want, otherwise I can merge like this. |
79ee359 to
5d7f3a2
Compare
I think this should be it.
Related links:
Generally:
This just uses the standard tracing json log format, depending on what we want to do in datadog we either need to pre-process these logs in datadog, or rename fields in here.
I'm not sure about the api-key / secret thing, feel free to tell me what should be different.
Also: these are just error / info logs from the wasm module itself. We don't have any access log yet.
Future improvements: