docs-rs CDN: generate request ID in CDN - #1197
Merged
Merged
Conversation
syphar
marked this pull request as ready for review
August 26, 2026 18:29
Member
Author
|
r? @marcoieni |
marcoieni
reviewed
Aug 28, 2026
| // Generate the request ID at the POP receiving the client request. On | ||
| // shield POPs, preserve the ID set by the edge POP. | ||
| if shield.response_is_for_client() { | ||
| req.set_header(X_REQUEST_ID, Uuid::new_v4().to_string()); |
Member
There was a problem hiding this comment.
did you consider using https://docs.rs/fastly/latest/fastly/struct.Request.html#method.get_client_request_id ?
Suggested change
| req.set_header(X_REQUEST_ID, Uuid::new_v4().to_string()); | |
| let request_id = req | |
| .get_client_request_id() | |
| .context("this is the client request, it should have a request ID")? | |
| .to_owned(); | |
| req.set_header(X_REQUEST_ID, request_id); |
Disclaimer: finding found by AI
Member
Author
There was a problem hiding this comment.
I think that's not what we want:
https://www.fastly.com/documentation/guides/compute/developer-guides/sandbox-lifecycle/#per-request-id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will be useful for application and access logs later.
Also we will see it on our origin servers.