Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the UIScene lifecycle on iOS, unlocking winit support for apps built with the iOS 27 SDK.
iOS 27 refuses to launch apps built with its SDK unless they adopt the UIScene lifecycle by declaring a scene manifest in
Info.plist. In apps that declare one, winit shows a blank screen: it creates its window before a scene exists and never attaches it to one.Related: #4224
Changes
can_create_surfacesis emitted once the first scene connects, instead of at launch.Impact
Testing
I wrote XCUITests that launch a winit app and check that its window appears, run with and without a scene manifest on the iOS 17, 26 and 27 simulators.
tvOS and visionOS are untested.
A backport to 0.30.13 is on
uiscene-minimal-v0.30; happy to open a PR againstv0.30.xif wanted.changelogmodule if knowledge of this change could be valuable to users