rcgen: stop storing key DER in KeyPair - #453
Open
djc wants to merge 2 commits into
Open
Conversation
djc
force-pushed
the
no-key-pair-der
branch
from
September 11, 2026 12:52
940aa67 to
2b77217
Compare
djc
force-pushed
the
no-key-pair-der
branch
from
September 11, 2026 13:02
2b77217 to
48e6f58
Compare
jgreeer
reviewed
Sep 11, 2026
Comment on lines
+745
to
+746
| PrivateKeyDer::Pkcs1(_) => "EC PRIVATE KEY", | ||
| PrivateKeyDer::Sec1(_) => "RSA PRIVATE KEY", |
Contributor
There was a problem hiding this comment.
Suggested change
| PrivateKeyDer::Pkcs1(_) => "EC PRIVATE KEY", | |
| PrivateKeyDer::Sec1(_) => "RSA PRIVATE KEY", | |
| PrivateKeyDer::Pkcs1(_) => "RSA PRIVATE KEY", | |
| PrivateKeyDer::Sec1(_) => "EC PRIVATE KEY", |
PKCS 1 is RSA and SEC1 is EC?
| f.debug_struct("KeyPair") | ||
| .field("kind", &self.kind) | ||
| .field("alg", &self.alg) | ||
| .field("serialized_der", &"[secret key elided]") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First semver-incompatible PR on
mainfor 0.15.0.Preparation for
cc @jgreeer