Skip to content

Update parser.js from mint repo - #100

Merged
kylekthompson merged 1 commit into
mainfrom
parser-update-0eb9af1610ec4fb0baf61d452fa0c6aa
Aug 27, 2026
Merged

Update parser.js from mint repo#100
kylekthompson merged 1 commit into
mainfrom
parser-update-0eb9af1610ec4fb0baf61d452fa0c6aa

Conversation

@rwx-cloud-bot

@rwx-cloud-bot rwx-cloud-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

This PR was generated from https://cloud.rwx.com/rwx/runs/0eb9af1610ec4fb0baf61d452fa0c6aa

Updates support/parser.js to the latest build from the mint repository.

Review checklist

  • Run the /review-parser-update skill in the language server repo to audit the parser for any required downstream code changes.

@rwx-cloud-bot
rwx-cloud-bot Bot requested a review from a team August 27, 2026 13:10
@rwx-cloud-bot

rwx-cloud-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

Parser update review

Claude reviewed the parser update and changed no files.

Review complete. Summary of findings on support/parser.js update (branch parser-update-0eb9af1610ec4fb0baf61d452fa0c6aa vs origin/main):

Step 1 — Parser changes: The raw diff is huge (~22k lines) but almost entirely cosmetic — esbuild's numeric variable-suffix renumbering across the bundled dependencies (yaml, typebox, chevrotain) and the persisted schema version history (a new v141 snapshot was added, itself just a renumbered copy of v140). After isolating and diffing the actual grammar module (packages/task-parser/yaml-dsl/parser2.ts and its sibling modules — common.ts, cron-parser.ts, matchers/*, template*.ts, base-layer/*), there is exactly one functional change:

-    if (coerceBaseOsToImage() && fields.os !== void 0) {
+    if (fields.os !== void 0) {

The coerceBaseOsToImage() feature-flag gate was removed — the deprecated base.os/base.tagbase.image/base.config coercion (with the existing deprecation tip) is now unconditional instead of flag-gated. No new/removed YAML keys, no new types, no changed parse-method names.

Step 2 — parser.d.ts: No changes needed. PartialBaseLayer already models os, image, config, tag, arch as optional strings — the coercion behavior change doesn't alter the type shape. Confirmed via npx tsc --noEmit (clean).

Step 3 — key-descriptions.ts: No changes needed. Ran npm run check-key-descriptions — zero MISSING, zero STALE keys.

Step 4 — arrayKeys in src/server.ts: No changes needed — no new array-valued keys were introduced.

Step 5 — Verification: npx tsc --noEmit clean, npm test → 129/129 passing across all 8 test files.

Net result: no source changes are required for this parser update; git status is clean. Nothing further to commit.

Claude Code session 7bbf1f99-0e8e-4ced-a2c4-e1ca819c6dbe. The full transcript is in the claude-output.json artifact of the review-parser-update task.

@kylekthompson
kylekthompson merged commit c595f01 into main Aug 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant