Skip to content

Shoulder Surfing Compat#960

Merged
Ocelot5836 merged 1 commit into
mainfrom
feature/shoulder-surfing-compat
Jun 18, 2026
Merged

Shoulder Surfing Compat#960
Ocelot5836 merged 1 commit into
mainfrom
feature/shoulder-surfing-compat

Conversation

@Ocelot5836

Copy link
Copy Markdown
Collaborator
  • Implements compat for shoulder surfing
  • The shoulder surfing camera angle is incorrect when riding on a sub-level

@Ocelot5836 Ocelot5836 self-assigned this May 19, 2026
@Ocelot5836 Ocelot5836 added the compatibility Issues when another mod is installed label May 19, 2026
@Ocelot5836 Ocelot5836 linked an issue May 19, 2026 that may be closed by this pull request
@Ocelot5836 Ocelot5836 changed the title Add partial shoulder surfing compat Shoulder Surfing Compat May 19, 2026
@EarthKing339

Copy link
Copy Markdown

How do I use or implement this into everything

@YassiGame

Copy link
Copy Markdown

@EarthKing339

How do I use or implement this into everything

Just keep in mind that this is a draft PR, so it may not work yet (but the build passes so maybe everything is fine)

You will need git and java 21 (or any higher... i think)

# Open the terminal in a empty folder

git clone https://github.com/ryanhcode/sable.git .
git fetch origin pull/960/head:pr-960
git checkout pr-960

# MacOS or Linux
./gradlew build

# Windows
gradlew.bat build

After that you wil have a built jar of sable with this fixes in neoforge/build/libs (I’m saying this from memory, I’m a bit too lazy to check the source code, but that should be the right path)

@Exopandora

Copy link
Copy Markdown

The shoulder surfing camera angle is incorrect when riding on a sub-level

The root cause for that is that Shoulder Surfing calls Camera.setRotation once again after Camera.move for camera sway (see MixinCamera of Shoulder Surfing). The mixins of sable then apply the sublevel rotation an additional time (see CameraMixin of sable), which messes up the camera position. A fix would be to not change the implementation of Camera.setRotation, but instead use a redirect or to apply the camera rotation adjustments directly after each setRotation call in the setup method.

* Implements compat for shoulder surfing
* The shoulder surfing camera angle is incorrect when riding on a sub-level
@Ocelot5836 Ocelot5836 force-pushed the feature/shoulder-surfing-compat branch from 3800bf0 to eaeec46 Compare June 18, 2026 03:36
@CLAassistant

CLAassistant commented Jun 18, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Ocelot5836 Ocelot5836 force-pushed the feature/shoulder-surfing-compat branch from 3e6e300 to eaeec46 Compare June 18, 2026 04:29
@Ocelot5836 Ocelot5836 marked this pull request as ready for review June 18, 2026 04:31
@Ocelot5836 Ocelot5836 merged commit 66505e7 into main Jun 18, 2026
5 checks passed
@Ocelot5836 Ocelot5836 deleted the feature/shoulder-surfing-compat branch June 18, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility Issues when another mod is installed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shoulder surfing reloaded

5 participants