Skip to content

fix: Correct scripts/get.sh for ambiguous file extension - #6300

Closed
Benjamin-Loison wants to merge 1 commit into
scaleway:mainfrom
Benjamin-Loison:main
Closed

Benjamin-Loison wants to merge 1 commit into
scaleway:mainfrom
Benjamin-Loison:main

Conversation

@Benjamin-Loison

@Benjamin-Loison Benjamin-Loison commented Sep 28, 2026 •

Copy link
Copy Markdown

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #6299

curl -s https://api.github.com/repos/scaleway/scaleway-cli/releases/latest | grep "browser_download_url.*${os}_${arch}\"" | cut -d : -f 2,3 | tr -d \" | tr -d " "
https://github.com/scaleway/scaleway-cli/releases/download/v2.63.0/scaleway-cli_2.63.0_linux_amd64

I tested successfully update and install thanks to my changes.

Until this pull request is merged, a workaround is:

curl -s https://raw.githubusercontent.com/Benjamin-Loison/scaleway-cli/049a6a50838f40ba08f2c48cfa21f223cf89c066/scripts/get.sh | sh

@Benjamin-Loison
Benjamin-Loison force-pushed the main branch 2 times, most recently from a91bc32 to 049a6a5 Compare September 28, 2026 21:46
@Benjamin-Loison Benjamin-Loison changed the title Fix #6299: Correct scripts/get.sh for ambiguois file extension fix: Correct scripts/get.sh for ambiguous file extension Sep 28, 2026
@Benjamin-Loison
Benjamin-Loison marked this pull request as ready for review September 28, 2026 21:47
remyleone
remyleone previously approved these changes Sep 29, 2026
@remyleone

Copy link
Copy Markdown
Member

Thanks @Benjamin-Loison for your contribution :)

@remyleone

Copy link
Copy Markdown
Member

@Benjamin-Loison Could you push signed commits?

@Benjamin-Loison

Benjamin-Loison commented Sep 29, 2026 •

Copy link
Copy Markdown
Author

I am working on it @remyleone. My commit is signed, but not at GitHub taste, I am investigating at Benjamin_Loison/Improve_websites_thanks_to_open_source/issues/4138.

auto-merge was automatically disabled September 29, 2026 13:49

Head branch was pushed to by a user without write access

@Benjamin-Loison

Copy link
Copy Markdown
Author

@remyleone it should be good now.

@elwinar

elwinar commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Nope, still not verified dixit github.

@elwinar

elwinar commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

So, we've got more people raising issues about this on multiple channels, so I've cherry-picked your commit and signed it as committer, which github will allow. This should give you attribution correctly (of the commit if not the MR).

@elwinar elwinar closed this Sep 30, 2026
@Benjamin-Loison

Benjamin-Loison commented Sep 30, 2026 •

Copy link
Copy Markdown
Author

Thank you for paying attention to attribution. I forgot to git push --force it seems, anyway upstream corrected that's the most important.

Personal notes: Benjamin_Loison/git/issues/153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

scripts/get.sh silent error blocking install and update

3 participants