CLDSRV-926: skip async/await diff check when PR has skip-async-migration label#6189
Closed
DarkIsDude wants to merge 3 commits into
Closed
CLDSRV-926: skip async/await diff check when PR has skip-async-migration label#6189DarkIsDude wants to merge 3 commits into
DarkIsDude wants to merge 3 commits into
Conversation
❌ 2 Tests Failed:
View the full list of 3 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
|
LGTM |
francoisferrand
approved these changes
Jun 17, 2026
| - name: Check async/await compliance in diff | ||
| run: yarn run check-diff-async | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Contributor
There was a problem hiding this comment.
nit: github.token can be used instead, and better IMHO (can be used in default parameters or actions, not a "fake" secret created temporarily...)
Comment on lines
+115
to
+116
| if gh pr list --head "$BRANCH_NAME" --state open --json labels \ | ||
| --jq '.[].labels[].name' 2>/dev/null | grep -qx 'skip-async-migration'; then |
Contributor
There was a problem hiding this comment.
nit: can't we use the --label parameter to get only skip-async-migration PRs?
if gh pr list --head "$BRANCH_NAME" --state open --label skip-async-migration ; then
maeldonn
approved these changes
Jun 18, 2026
delthas
approved these changes
Jun 18, 2026
|
LGTM |
Contributor
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull-requests: readpermission to thetests.yamlworkflowskip-async-migrationlabel before runningcheck-diff-asyncBehaviour
skip-async-migrationlabelcheck-diff-asyncruns normallyworkflow_dispatch)check-diff-asyncruns normallyPre-requisite
The
skip-async-migrationlabel must be created in the repository settings before use.Closes CLDSRV-926