Adopt the shared Claude review skill and modernize the review workflow by delthas · Pull Request #6194 · scality/cloudserver

delthas · 2026-06-18T18:24:39Z

Summary

Two related changes bringing CloudServer's Claude review CI up to the shared standard (vault2 / Zenko / pensieve-api / zenko-operator).

1. Adopt the shared review skill

Move CloudServer's repo-specific review criteria from the vendored .claude/skills/review-pr/SKILL.md into .github/copilot-instructions.md (read by the marketplace skill).
Delete the vendored skill — the reusable claude-code-review.yml@v2 workflow already loads scality-skills@scality-agent-hub, and the vendored copy otherwise shadows it at runtime.
CLAUDE.md stays as repo context.

This supersedes the vendored-skill formatting fix in CLDSRV-880 / #6125 — once the skill is deleted, it lives only in agent-hub.

2. Modernize the review workflow

Forward secrets via secrets: inherit (instead of enumerating each one in both jobs).
Add a dynamic run-name and a workflow_dispatch trigger (with pr_number input) for manual re-runs, plus the allowed-tools passthrough.
The review job now also runs on workflow_dispatch (guarded off only for pull_request_target + dependabot). The existing review-dependency-bump job is unchanged.

Note: prettier re-indented review.yml to the repo's 4-space YAML style (it had never been prettier-checked before, since prettier only runs on changed files), which inflates the diff — the semantic changes are the secrets/run-name/dispatch ones above.

Issue: CLDSRV-930

bert-e · 2026-06-18T18:24:43Z

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

codecov · 2026-06-18T18:27:19Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.50%. Comparing base (a8e3605) to head (c17953d).
⚠️ Report is 2 commits behind head on development/9.2.
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.2    #6194      +/-   ##
===================================================
- Coverage            84.51%   84.50%   -0.02%     
===================================================
  Files                  204      204              
  Lines                13217    13217              
===================================================
- Hits                 11171    11169       -2     
- Misses                2046     2048       +2

Flag	Coverage Δ
file-ft-tests	`68.12% <ø> (-0.06%)`	⬇️
kmip-ft-tests	`28.41% <ø> (ø)`
mongo-v0-ft-tests	`69.35% <ø> (-0.03%)`	⬇️
mongo-v1-ft-tests	`69.40% <ø> (ø)`
multiple-backend	`35.68% <ø> (ø)`
sur-tests	`36.80% <ø> (ø)`
sur-tests-inflights	`37.80% <ø> (-0.04%)`	⬇️
unit	`70.34% <ø> (ø)`
utapi-v2-tests	`34.69% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bert-e · 2026-06-18T18:41:45Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

Drop the vendored .claude/skills/review-pr/SKILL.md and rely on the shared scality-skills marketplace skill loaded by the reusable review workflow. Move CloudServer's repo-specific review criteria into .github/copilot-instructions.md (read by the marketplace skill), keeping CLAUDE.md as repo context. Matches the vault2 layout. Issue: CLDSRV-930

claude · 2026-06-19T07:41:29Z

LGTM

Review by Claude Code

francoisferrand

don't we need to upgrade the GHA workflow file to latest standards as well?

Forward secrets via `secrets: inherit`, add a dynamic run-name, and add a workflow_dispatch trigger (with pr_number input) for manual re-runs plus the allowed-tools passthrough. The review job now also runs on workflow_dispatch (guarded off only for pull_request_target and dependabot). Keeps the existing dependency-bump job. Issue: CLDSRV-930

delthas · 2026-06-19T09:55:58Z

don't we need to upgrade the GHA workflow file to latest standards as well?

Done

delthas · 2026-06-19T09:57:05Z

/approve

bert-e · 2026-06-19T09:57:17Z

Conflict

A conflict has been raised during the creation of
integration branch w/9.4/improvement/CLDSRV-930/adopt-shared-review-skill with contents from w/9.3/improvement/CLDSRV-930/adopt-shared-review-skill
and development/9.4.

I have not created the integration branch.

Here are the steps to resolve this conflict:

 git fetch
 git checkout -B w/9.4/improvement/CLDSRV-930/adopt-shared-review-skill origin/development/9.4
 git merge origin/w/9.3/improvement/CLDSRV-930/adopt-shared-review-skill
 # <intense conflict resolution>
 git commit
 git push -u origin w/9.4/improvement/CLDSRV-930/adopt-shared-review-skill

The following options are set: approve

bert-e · 2026-06-19T10:16:07Z

Build failed

The build for commit did not succeed in branch w/9.3/improvement/CLDSRV-930/adopt-shared-review-skill

The following options are set: approve

bert-e · 2026-06-19T10:35:25Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/9.2
✔️ development/9.3
✔️ development/9.4

The following branches have NOT changed:

development/7.10
development/7.4
development/7.70
development/8.8
development/9.0
development/9.1

This pull request did not target the following hotfix branch(es) so they
were left untouched:

hotfix/7.10.15
hotfix/7.70.73
hotfix/7.4.5
hotfix/7.10.0
hotfix/6.4.7
hotfix/7.10.30
hotfix/7.10.49
hotfix/7.4.4
hotfix/7.6.0
hotfix/7.70.51
hotfix/7.4.1
hotfix/7.10.28
hotfix/7.9.0
hotfix/7.4.9
hotfix/7.4.0
hotfix/7.4.8
hotfix/7.7.0
hotfix/7.70.45
hotfix/7.4.7
hotfix/9.0.32
hotfix/7.70.11
hotfix/7.10.1
hotfix/7.2.0
hotfix/7.8.0
hotfix/7.70.21
hotfix/7.10.8
hotfix/7.10.3
hotfix/7.4.6
hotfix/7.4.3
hotfix/7.10.27
hotfix/8.8.45
hotfix/7.10.4
hotfix/7.4.10
hotfix/9.2.24
hotfix/7.10.2
hotfix/7.4.2
hotfix/9.0.7

Please check the status of the associated issue CLDSRV-930.

Goodbye delthas.

The following options are set: approve

scality deleted a comment from bert-e Jun 18, 2026

delthas force-pushed the improvement/CLDSRV-930/adopt-shared-review-skill branch from d8b5e6c to 45108ee Compare June 19, 2026 07:40

delthas changed the base branch from development/9.3 to development/9.2 June 19, 2026 07:40

scality deleted a comment from bert-e Jun 19, 2026

scality deleted a comment from claude Bot Jun 19, 2026

scality deleted a comment from bert-e Jun 19, 2026

delthas requested review from a team, DarkIsDude and SylvainSenechal June 19, 2026 07:46

francoisferrand approved these changes Jun 19, 2026

View reviewed changes

DarkIsDude approved these changes Jun 19, 2026

View reviewed changes

delthas changed the title ~~Adopt the shared Claude review skill (drop vendored copy, add copilot-instructions)~~ Adopt the shared Claude review skill and modernize the review workflow Jun 19, 2026

bert-e merged commit c17953d into development/9.2 Jun 19, 2026
33 checks passed

bert-e deleted the improvement/CLDSRV-930/adopt-shared-review-skill branch June 19, 2026 10:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adopt the shared Claude review skill and modernize the review workflow#6194

Adopt the shared Claude review skill and modernize the review workflow#6194
bert-e merged 2 commits into
development/9.2from
improvement/CLDSRV-930/adopt-shared-review-skill

delthas commented Jun 18, 2026 •

edited

Loading

Uh oh!

bert-e commented Jun 18, 2026

Uh oh!

codecov Bot commented Jun 18, 2026 •

edited

Loading

Uh oh!

bert-e commented Jun 18, 2026

Uh oh!

claude Bot commented Jun 19, 2026

Uh oh!

francoisferrand left a comment

Uh oh!

delthas commented Jun 19, 2026

Uh oh!

delthas commented Jun 19, 2026

Uh oh!

bert-e commented Jun 19, 2026

Uh oh!

bert-e commented Jun 19, 2026

Uh oh!

bert-e commented Jun 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

delthas commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

1. Adopt the shared review skill

2. Modernize the review workflow

Uh oh!

bert-e commented Jun 18, 2026

Hello delthas,

Uh oh!

codecov Bot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bert-e commented Jun 18, 2026

Request integration branches

Uh oh!

claude Bot commented Jun 19, 2026

Uh oh!

francoisferrand left a comment

Choose a reason for hiding this comment

Uh oh!

delthas commented Jun 19, 2026

Uh oh!

delthas commented Jun 19, 2026

Uh oh!

bert-e commented Jun 19, 2026

Conflict

Uh oh!

bert-e commented Jun 19, 2026

Build failed

Uh oh!

bert-e commented Jun 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

delthas commented Jun 18, 2026 •

edited

Loading

codecov Bot commented Jun 18, 2026 •

edited

Loading