Skip to content

👷 CLDSRV-926: skip async/await diff check when PR has skip-async-migration label#6195

Open
DarkIsDude wants to merge 3 commits into
development/9.3from
feature/CLDSRV-926/skip-async-check
Open

👷 CLDSRV-926: skip async/await diff check when PR has skip-async-migration label#6195
DarkIsDude wants to merge 3 commits into
development/9.3from
feature/CLDSRV-926/skip-async-check

Conversation

@DarkIsDude

Copy link
Copy Markdown
Contributor

Summary

  • Adds pull-requests: read permission to the tests.yaml workflow
  • The "Check async/await compliance in diff" step now checks whether the current branch's open PR carries the skip-async-migration label before running check-diff-async
  • If the label is present the step exits cleanly; otherwise the check runs as before

Behaviour

Scenario Result
PR has skip-async-migration label Step skips, exits 0
PR does not have the label check-diff-async runs normally
No open PR (direct push / workflow_dispatch) check-diff-async runs normally

Pre-requisite

The skip-async-migration label must be created in the repository settings before use.

Closes CLDSRV-926

@DarkIsDude DarkIsDude self-assigned this Jun 19, 2026
@bert-e

bert-e commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Hello darkisdude,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-926 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.3.11

  • 9.4.0

Please check the Fix Version/s of CLDSRV-926, or the target
branch of this pull request.

@DarkIsDude

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1
  • development/9.2

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e

bert-e commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: approve

@bert-e

bert-e commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Build failed

The build for commit did not succeed in branch w/9.4/feature/CLDSRV-926/skip-async-check

The following options are set: approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants