Add enclosing ranges for Go declarations - #298
Merged
jupblb merged 2 commits intoSep 26, 2026
Merged
Conversation
jupblb
requested changes
Sep 25, 2026
Contributor
Author
|
After addressing the comment on the
What do you think? Should I go ahead and extend the PR scope to cover for these use cases? |
jupblb
approved these changes
Sep 26, 2026
jupblb
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution! LGTM :)
What do you think? Should I go ahead and extend the PR scope to cover for these use cases?
These are all good observations but I'd prefer these changes are made in another PR, if that's not too much to ask.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #297.
Emit typed enclosing ranges for type, var/const, and struct-field definitions, including attached docs, and declare UTF-8 byte positions. Existing function ranges and primary occurrence sites remain unchanged.
Validation:
go test ./...; on the frozen Go fixture, valid definition enclosures increased 27/150 → 58/150 with all 471 primary sites unchanged. A separate Code IR shadow recheck joined 117/117 selected-local candidates.