Conversation
Signed-off-by: Keys <70819367+keys-i@users.noreply.github.com>
Signed-off-by: Keys <70819367+keys-i@users.noreply.github.com>
also added in a checks to fmt + clippy + test it Signed-off-by: Keys <70819367+keys-i@users.noreply.github.com>
Signed-off-by: Keys <70819367+keys-i@users.noreply.github.com>
|
Review: LOW risk, approve after one thing is fixed.
One meta note for future PRs: could we lean toward smaller, single-purpose PRs going forward? This one bundles a security fix, Rust hardening, and a CI refactor, which makes it harder to review each change on its merits and to bisect later if something regresses. Not a blocker here — just a preference for splitting things up next time. Thanks! |
|
Actually, I'll veto this one. It's a massive PR that touches way too much. I want small, fine grained PRs with well expressed intent. It makes reviewing easier and lowers the risk unwanted things creeping in. |
|
@keys-i I'd love to incorporate your workflow changes and file layout stuff. We never discussed broad changes to the code. Let's take these improvements one step at a time please. |
Closes #454, #455
Summary
src/bin/<command>/main.rstosrc/bin/<command>.rs.Verification
cargo fmt --all -- --checkcargo clippy --locked --all-targets --all-features -- -D warningscargo test --locked— 50 passedactionlint .github/workflows/*.ymlgit diff --checkNotes