Skip to content

Flatten Rust binaries and fix README header title - #456

Merged
chloe41427[bot] merged 3 commits into
sdkman:masterfrom
keys-i:rust-rename
Sep 3, 2026
Merged

Flatten Rust binaries and fix README header title#456
chloe41427[bot] merged 3 commits into
sdkman:masterfrom
keys-i:rust-rename

Conversation

@keys-i

@keys-i keys-i commented Sep 3, 2026

Copy link
Copy Markdown
Contributor
  • Flatten Rust binaries from src/bin/<command>/main.rs to src/bin/<command>.rs.
  • Fix the README header title.

Verification

  • cargo fmt --all -- --check
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • cargo test --locked — 50 passed
  • git diff --check

Note

Binary flattening preserves Cargo’s existing command behavior.

keys-i added 3 commits August 24, 2026 08:55
Signed-off-by: Keys <70819367+keys-i@users.noreply.github.com>
Signed-off-by: Keys <70819367+keys-i@users.noreply.github.com>
@keys-i keys-i changed the title Rust rename Flatten Rust binaries and fix README header title Sep 3, 2026

@chloe41427 chloe41427 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. This is a clean, low-risk mechanical change:

  • Renames src/bin/<cmd>/main.rssrc/bin/<cmd>.rs for current, default, help, home, uninstall, version, with their snapshot tests moved alongside. All renames are 100% similarity — no logic changed, and Cargo's binary discovery treats both layouts identically, so command behavior is preserved.
  • Fixes a duplicate H1 in the README (there were two # SDKMAN!... headers stacked).
  • Net diff is trivial despite touching 21 files — almost entirely renames.
  • CI green on macOS, Ubuntu, and Windows. cargo fmt, clippy -D warnings, and cargo test (50 passed) all verified per the PR description.

No concerns. Approving.

@chloe41427
chloe41427 Bot merged commit eda931d into sdkman:master Sep 3, 2026
3 checks passed
@marc0der

marc0der commented Sep 3, 2026

Copy link
Copy Markdown
Member

Thanks for contributing @keys-i 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants