Update to rn0.83#9
Open
sunitaprajapati89 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amazon Vega SDK 0.24 adds React Native 0.83 support. Existing Vega apps on
RN 0.72 will migrate to RN 0.83, and the current
@segment/analytics-react-native-plugin-kepler (v1.0.0) pins Amazon
dependencies on the RN 0.72 line. Update the plugin's @amazon-devices/*
dependencies and RN toolchain to the RN 0.83 line, verify against Vega SDK
0.24, and publish a new version to npm so Segment support is available for
Vega apps on RN 0.83.
IMPORTANT: Do not modify the version currently consumed by RN 0.72 Vega
apps. Bump the version number and publish a new release; existing RN 0.72
apps migrate on their own timeline.
BACKGROUND
The plugin provides Segment analytics for Amazon Vega RN apps. It wires
Vega-specific providers into the core SDK: deviceInfoProvider
(@amazon-devices/react-native-device-info + -localize), storePersistor
(Amazon's AsyncStorage fork), and KeplerUUIDProvider.
The @amzn/* -> @amazon-devices/* namespace migration is already complete
in the current source; no namespace work remains.
@amazon-devices/* packages are published to public npm; no .npmrc auth
token is required.
Related prior art: analytics-react-native/notes/rn-upgrade.md documents
the core SDK's RN 0.84 / New-Architecture upgrade. Many toolchain changes
(babel preset, metro config, gradle) apply to this 0.83 bump.
DEPENDENCY UPDATES
@amazon-devices/react-native-kepler
current: ~2.0.0
target: 4.0.0
@amazon-devices/react-native-device-info
current: ^2.0.0
target: 2.1.9000000000-rn-83
@amazon-devices/react-native-localize
current: ~2.0.0
target: 2.1.9000000000-rn-83
@amazon-devices/react-native-async-storage__async-storage
current: ~2.0.0 (via overrides + aliased peer)
target: 2.1.9000000000-rn-83
FILES TO CHANGE (analytics-react-native-plugin-kepler)
package.json -- peerDependencies (lines ~48-54) and overrides
(lines ~56-58) for all four Amazon packages above.
package.json devDependencies -- bump RN toolchain 0.72 -> 0.83:
react-native (^0.72.0), @types/react-native (0.72.6); swap
metro-react-native-babel-preset -> @react-native/babel-preset; bump
react-native-builder-bob, @react-native/eslint-config, and
react / @types/react as needed for 0.83.
example/package.json -- bump react-native (0.72.0 -> 0.83.x), the three
@amazon-devices/* deps + async-storage alias, and the kepler/CLI tooling
to the Vega SDK 0.24 line.
Evaluate bumping the @segment/analytics-react-native peer/dev dependency
from the pinned pre-release 2.20.0-beta.2 to the current core release
(2.21.4).
Bump plugin version and publish a new npm release.
ACCEPTANCE CRITERIA
[ ] Plugin package.json peer deps + overrides updated to the RN 0.83
versions above.
[ ] Plugin builds cleanly (bob build); tsc --noEmit and tests pass on the
RN 0.83 toolchain.
[ ] Example app builds and runs on Vega SDK 0.24 (RN 0.83); events reach
Segment -- verify track/identify, deviceInfoProvider, storage
persistence, and UUID generation.
[ ] New plugin version published to npm; version bumped, existing RN 0.72
release untouched.
[ ] README updated if any install/usage steps change for RN 0.83.
NOTES / RISKS
Known plugin limitations remain (per README):
react-native-device-info returns unknown/empty for some context fields;
trackDeepLinks and native anonymousId unsupported. Re-check whether
device-info 2.1.9...-rn-83 fills any hardcoded TODO fields in
src/device-info.ts (networkType, screenHeight, screenWidth).
The -rn-83 version suffixes are Amazon early-access build identifiers and
may change before GA -- confirm final published versions on npm before
publishing.
RN 0.72 -> 0.83 is a large jump; expect babel/metro config churn in the
example app. Reuse patterns from notes/rn-upgrade.md.