Repository navigation
fix(zsh): Starship prompt ownership with Oh My Zsh - #12
Merged
Merged
Conversation
added 5 commits
September 30, 2026 23:19
Initialize Starship for Zsh when prompt_starship_precmd hooks are absent, instead of trusting inherited STARSHIP_SHELL from parent shells or tmux.
Add isolated OMZ stub tests for STARSHIP_SHELL inheritance, idempotent reload, fallback prompt, and local PROMPT override behavior.
Report Starship hook registration and config deployment; probe with inherited STARSHIP_SHELL=bash to catch the regression on health checks.
Avoid hard-coding patch numbers so release bumps do not break macOS smoke.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prompt_starship_precmdhook presence, not inheritedSTARSHIP_SHELL../scripts/check.shwith a Prompt section that probesSTARSHIP_SHELL=bash.Test plan
./scripts/ci/lint.sh./scripts/ci/test.sh(local)bash scripts/tests/zsh_prompt_starship_test.shSTARSHIP_SHELL=bash zsh -icshows Starship hooks