Check for null on authorization use when searching for it#1480
Merged
Conversation
fjtirado
force-pushed
the
check_null_auth
branch
from
ed3469a to
d093b2b
Compare
Signed-off-by: fjtirado <ftirados@ibm.com>
fjtirado
force-pushed
the
check_null_auth
branch
from
d093b2b to
52aa526
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates AuthProviderFactory to avoid a NullPointerException when resolving authentication providers by reference and the workflow’s use section is missing.
Changes:
- Added explicit null handling for
workflow.getUse()inbuildFromReference(...). - Refactored
buildFromReference(...)to use local variables forUse/UseAuthentications.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mcruzdev
approved these changes
Jun 23, 2026
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the definition contains a reference to an auth use, but the use section is null, a NullPointerException was thrown, the proper thing to do was to return an optional empty and move on.