Wait executor should use provided executor rather than global one#1482
Merged
Conversation
Signed-off-by: fjtirado <ftirados@ibm.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the WaitExecutor implementation so that the wait-completion work is executed using the WorkflowApplication-provided ExecutorService, instead of relying on the default/global executor behavior from CompletableFuture.completeOnTimeout.
Changes:
- Replaced
completeOnTimeout(...)with an explicitCompletableFutureplus a delayed execution path that targetsworkflow.definition().application().executorService(). - Adjusted the wait completion logic to complete the returned future via an executor-scheduled runnable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
completeOnTimeoput uses a global internal thread.
This PR change WaitExecutor implementation to use the provided Applicaiton.ExecutorService