Fix android linking in CI - #804
Open
jschwe wants to merge 2 commits into
Open
Conversation
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
- Adjust the script to support macos - Exit early if missing --target - Use cross-compile wrappers - Set the linker, so we can link tests Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jschwe
marked this pull request as ready for review
August 24, 2026 18:54
Member
Author
|
Okay, cherry-picked onto the 153 branch the tests still build and link, so thats good (only tested with the 28 NDK though). |
sagudev
reviewed
Aug 24, 2026
Member
There was a problem hiding this comment.
Wouldn't this be replaced by cargo-ndk?
Member
Author
There was a problem hiding this comment.
Yes it would be. I don't think I'll have time for working on a cargo-ndk PR in the close future though (it might just work, but chances are it doesn't)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing: This adds linking the unit-tests for android to CI