chore: bump SGLang to 0.5.18 - #787
Merged
Merged
Conversation
maocheng23
requested review from
FlamingoPg,
FrankLeeeee,
shuaills and
sleepcoo
as code owners
August 28, 2026 19:22
Collaborator
|
LGTM. But when we set |
jiapingW
self-requested a review
August 29, 2026 02:54
jiapingW
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comparison with #605
The v0.5.14 base and Ascend patches are now replaced directly by their v0.5.18 ports. GitHub recognizes both as renames:
The whole PR is +693/-361. Excluding those versioned patch deltas, the hand-written integration change is +512/-243 (755 changed lines), slightly less than #605's +627/-139 (766 changed lines).
PR #605 merged before the checked-in online capture patch and live capture gate were added. This upgrade therefore also has to port a 12-file SGLang server patch that #605 did not contain.
CI fixes
The first PR Test restored a cached
sfvirtualenv containing the v0.5.14 patch record and patch-added sink file. Pip replaced SGLang's package-owned files with v0.5.18 but left those unowned files. The installer then used BSDpatch --reverse, which ignored the requested direction, accepted fuzz/offsets, partially applied old hunks, and failed before the live test started.The installer now uses exact, atomic
git applychecks. It recovers only the recognized pip-upgrade residue when the installed version matches the target and the new patch applies exactly; ambiguous states are restored unchanged and rejected. Regression tests cover recovery, idempotence, failure restoration, and rejection of the removed v0.5.14 target.The restored venv also retained
flashinfer-cubin==0.6.12while SGLang 0.5.18 installedflashinfer-python==0.6.17. CUDA CI now mirrors upstream SGLang and explicitly installs the matching 0.6.17 cubin. The full GPU suite then exposed two v0.5.18 offline API requirements, now handled by initializing each request's extend range and passingreturn_hidden_states_before_norm=FalsetoForwardBatch.init_new.Validation
sglang==0.5.18,torch==2.13.0+cu130, andtransformers==5.12.1v0.5.18checkout