refactor(ui): drop the devices list's unreachable status filter - #7071
Merged
Conversation
The list hid every status tab but accepted and an effect forced the parameter back, so the pending and rejected column sets, their tabs and the accept/reject/remove dialog could not be reached by any URL. Acceptance is reviewed on the install keys list, so the tab that used to filter is one link out to it.
|
Claude finished @gustavosbarreto's task in 2m 27s —— View job Code Review CompleteReviewed 2 files across code quality, security, testing, language patterns, and architecture — no new issues found. The code looks good as-is. The change is a clean removal of the unreachable status filter. Verified along the way:
To request another review round, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The devices list still carries the code behind a filter no URL can reach.
visibleTabskeeps only the accepted tab and an effect forcesstatusback to accepted, so the pending and rejected column sets, their tabs and the accept/reject/remove dialog are unreachable, and the status constraint that validates the parameter has nothing left to validate.This is #7048's
4b0b34300, kept as its own change because #7070 answered the issue a different way and left the dead code in place. Same removal, with one adjustment: the tab that used to filter by pending now links to the install keys list, where the decision is actually made, rather than to the/pending-devicespage that PR proposed.That leaves the list with one status and one way out of it, so the two links collapse into the single Install Keys link the list already had.