Skip to content

refactor(ui): drop the devices list's unreachable status filter - #7071

Merged
gustavosbarreto merged 1 commit into
masterfrom
refactor/drop-devices-status-filter
Sep 10, 2026
Merged

refactor(ui): drop the devices list's unreachable status filter#7071
gustavosbarreto merged 1 commit into
masterfrom
refactor/drop-devices-status-filter

Conversation

@gustavosbarreto

Copy link
Copy Markdown
Member

The devices list still carries the code behind a filter no URL can reach. visibleTabs keeps only the accepted tab and an effect forces status back to accepted, so the pending and rejected column sets, their tabs and the accept/reject/remove dialog are unreachable, and the status constraint that validates the parameter has nothing left to validate.

This is #7048's 4b0b34300, kept as its own change because #7070 answered the issue a different way and left the dead code in place. Same removal, with one adjustment: the tab that used to filter by pending now links to the install keys list, where the decision is actually made, rather than to the /pending-devices page that PR proposed.

That leaves the list with one status and one way out of it, so the two links collapse into the single Install Keys link the list already had.

The list hid every status tab but accepted and an effect forced the
parameter back, so the pending and rejected column sets, their tabs and
the accept/reject/remove dialog could not be reached by any URL.

Acceptance is reviewed on the install keys list, so the tab that used to
filter is one link out to it.
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

Claude finished @gustavosbarreto's task in 2m 27s —— View job


Code Review Complete

Reviewed 2 files across code quality, security, testing, language patterns, and architecture — no new issues found. The code looks good as-is.

The change is a clean removal of the unreachable status filter. Verified along the way:

  • Removed hooks/components (useActionDialog, useDeviceActionRunner, ActionDialog) are still used by DeviceDetails/ContainerDetails — no dangling exports.
  • All removed imports (useEffect, cn, UseActionDialogResult, etc.) and local symbols (VALID_STATUSES, statusTabs) are fully cleaned up.
  • The columns useMemo dependency array matches its new body; the [hostnameColumn, ...detailColumns] destructure preserves the original column order.
  • status: "accepted" is now a fixed literal, so dropping the URL status whitelist strictly narrows (not weakens) client input — confirmed by the updated tests.
  • /install-keys is a real registered route; no /pending-devices route or ?status= consumer is left broken, and the cloud repo (Go-only) doesn't depend on this page.

To request another review round, comment /review.
· refactor/drop-devices-status-filter

@gustavosbarreto
gustavosbarreto enabled auto-merge (rebase) September 10, 2026 17:58
@gustavosbarreto
gustavosbarreto merged commit 3394963 into master Sep 10, 2026
42 checks passed
@gustavosbarreto
gustavosbarreto deleted the refactor/drop-devices-status-filter branch September 10, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants