ci(review): run the code-review skill's axes on a pull request - #7074
Merged
Conversation
The prompt lived inline here and in cloud's copy, 574 near-identical lines each, and the two had already drifted. It now comes from .claude/prompts/pr-review.md in the claude repo, leaving only this repo's specifics in the workflow. What the old prompt asked for was narrower than the review /code-review runs locally: it flagged compile errors and exploitable bugs while excluding "code style or quality concerns", so every documented-rule violation and every code smell was dropped before it could be posted, and nothing checked the diff against the issue it claims to implement.
|
Claude finished @otavio's task in 2m 1s —— View job Code Review CompleteReviewed 1 file across code quality, security, testing, language patterns, and architecture — no new issues found. The change is a clean, well-reasoned refactor. What I verified:
One operational note (already called out in the PR body, not a code issue): To request another review round, comment __ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The PR review workflow now executes the shared procedure from the
clauderepo instead of a 574-line prompt embedded in this file. The workflow keeps the plumbing and contributes a preamble naming this repo's specifics: the anonymous-route allowlist, which conventions skills apply, the extra correctness focus, and the cross-repo rule.Why
Two near-identical copies of the prompt (here and in
cloud) drifted, and both ran a weaker review than/code-reviewgives locally — no Spec axis, and a filter that discarded every convention and smell finding. See shellhub-io/claude#61 for the procedure and the full rationale.Changes
Load review procedurestep that reads the file viaGITHUB_OUTPUT. Reading it in a step rather than telling the agent to open the file keeps the review from depending on a tool call that can fail mid-run.gh pr viewandgh issue viewadded to--allowedTools— the Spec axis needs them to resolve the linked issue.--max-turns50 -> 80, and the model pinned toclaude-opus-5.Testing
Comment
/reviewon an open PR after shellhub-io/claude#61 merges. Watch for the tracking comment reaching a terminal state — the summary is mandatory, and theFinalize tracking commentstep rewrites it if the agent runs out of turns.