ci: finalize the review tracking comment in its own job - #7082
Merged
Conversation
As a step it shared a job with the review it exists to clean up after, so the job-level timeout — the only kind available inside a composite action — cancelled the finalize along with the hang that triggered it. A separate job also survives the runner dying, which the step never did. The job takes the claude branch the review job resolved, falling back to master when the review was cancelled before resolving one. Pinning master outright would mean a change to the finalize action could never be tested from a paired branch — as this very PR showed, by failing against a master that did not have the action yet. Also drops a comment that restated the commit body, which code-style.md bans.
otavio
force-pushed
the
ci/pr-review-config-reach
branch
from
September 12, 2026 14:26
42f9674 to
b37abb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with shellhub-io/claude#64, which carries the substance — including a fix for
claude-code-actionwiping the synced.claude/before the review runs, which has meant CI reviewsin this repo have not been reading the repo rules or the
code-reviewskill at all.What changes here
The tracking-comment finalize moves out of the review job into its own
needs: review, if: always()job. As a step it shared a job with the review it exists to clean up after, so the job-level
timeout — the only kind available inside a composite action — cancelled the finalize along with the
hang that triggered it. A separate job also survives the runner dying, which the step never did. It
checks out only the claude repo, at master, sparsely.
Also drops a three-line comment that restated the commit body, which
code-style.mdbans — flaggedby the automated review on shellhub-io/cloud#2549.
Testing
actionlint and yamllint clean.
As before, this PR does not exercise its own change:
pull_request_targetruns the workflow fromthe base branch. shellhub-io/cloud#2550 verifies the new path, including whether the reviewer can
now read
$GITHUB_WORKSPACE/claude/.claude/skills/code-review/SKILL.md.Merge order: claude#64, then cloud#2550 (check its run log for that read), then this one.