Conversation
sheredom
force-pushed
the
feature/terminate-on-parent-exit
branch
3 times, most recently
from
August 21, 2026 14:10
aa8ff91 to
c4a9b31
Compare
馃 Conjured by AI via [pi.dev](https://pi.dev/) using gpt-5.6-sol
sheredom
force-pushed
the
feature/terminate-on-parent-exit
branch
from
August 21, 2026 14:14
c4a9b31 to
f4963d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subprocess_option_terminate_on_parent_exitto terminate a managed subprocess tree when its parent exitsPROC_THREAD_ATTRIBUTE_JOB_LISTassignment on Windows 10+subprocess_destroyterminate opted-in running process treesRationale
The process-group design incorporates the lesson from Apache Commons Daemon DAEMON-232 and commit
cab468ff, which removed jsvc's unconditional startupsetpgrp/setpgidbehavior because it interfered with supervisors that signal logical process groups.The POSIX watchdog also closes its own lifeline write descriptor before waiting for EOF, matching the failure mode fixed by OpenJDK JDK-8307990.
Testing
ctest --test-dir build --output-on-failuresubprocess_testsubprocess_address_testsubprocess_undefined_testsubprocess_thread_testAll four local macOS CTest targets pass. Windows runtime and Linux behavior are covered by the repository CI matrix.
馃 Conjured by AI via pi.dev using gpt-5.6-sol