Fix Swift registry check using wrong separator in object name search - #37
Draft
imatza-rh wants to merge 1 commit into
Draft
Fix Swift registry check using wrong separator in object name search#37imatza-rh wants to merge 1 commit into
imatza-rh wants to merge 1 commit into
Conversation
The JSON-output migration in commit 1540a56 changed the Swift object search from grep (where '.' matches any character including '/') to jq contains() (where '.' is a literal dot). This caused the search target 'swift-check-NNNN.fooapp' to never match the actual Swift object paths which use '/' as separator: files/docker/registry/v2/repositories/swift-check-NNNN/fooapp/... Change the target separator from '.' to '/' to match the actual object name structure in Swift. Verified on live environment: old pattern matched 0 objects, new pattern correctly matches 7 objects. Fixes regression from 1540a56 (Harden verification OpenStack CLI calls to use JSON output). Assisted-By: Claude Code Signed-off-by: Itay Matza <imatza@redhat.com>
imatza-rh
requested review from
chenwng,
dlaw4608,
ekuris-redhat,
eshulman2,
gryf,
mandre,
stephenfin,
tusharjadhav3302 and
winiciusallan
as code owners
August 31, 2026 09:15
imatza-rh
marked this pull request as draft
August 31, 2026 09:17
ekuris-redhat
approved these changes
Sep 1, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekuris-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1540a56 migrated Swift object search from grep to jq. The dot in the search target was a regex wildcard in grep matching
/, but jqcontains()treats it as literal. Fix: change.to/in the target variable.Verified on titan35: old pattern 0 matches, new pattern 7 matches.