Skip to content

Update build v0.20.2 dependencies#399

Open
sayan-biswas wants to merge 1 commit into
shipwright-io:mainfrom
sayan-biswas:update-build-deps
Open

Update build v0.20.2 dependencies#399
sayan-biswas wants to merge 1 commit into
shipwright-io:mainfrom
sayan-biswas:update-build-deps

Conversation

@sayan-biswas

@sayan-biswas sayan-biswas commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

  • update build dependency to v0.20.0
  • fix streamer_test.go to work with updated kubernetes api.

/kind dependency-change

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Kind label has been set
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Copilot AI review requested due to automatic review settings June 23, 2026 07:43
@openshift-ci openshift-ci Bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 23, 2026
@openshift-ci openshift-ci Bot requested review from qu1queee and rxinui June 23, 2026 07:43
@openshift-ci openshift-ci Bot added release-note-none and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 23, 2026
Copilot AI reviewed Jun 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2026
@sayan-biswas sayan-biswas added kind/dependency-change Categorizes issue or PR as related to changing dependencies and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 23, 2026
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2026
@sayan-biswas

sayan-biswas commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

@SaschaSchwarze0 The snyk test is failing. Can we gave this PR merged?

SaschaSchwarze0
SaschaSchwarze0 requested changes Jun 29, 2026
View reviewed changes
Comment thread .idea/.gitignore Outdated
Comment thread cover.out Outdated
Comment thread coverage.out Outdated
@sayan-biswas
Update build v0.20.0 dependencies
dd9075c 
# Changes:
- update build dependency to v0.20.2
- fix streamer_test.go to work with updated kubernetes api.
- Rebuilds docs

Signed-off-by: Sayan Biswas <sabiswas@redhat.com>
@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign saschaschwarze0 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sayan-biswas sayan-biswas changed the title Update build v0.20.0 dependencies Update build v0.20.2 dependencies Jun 30, 2026
@sayan-biswas

sayan-biswas commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

@SaschaSchwarze0 Removed the unnecessary files.

SaschaSchwarze0
SaschaSchwarze0 reviewed Jun 30, 2026
View reviewed changes
Comment thread docs/shp.md
--kubeconfig string Path to the kubeconfig file to use for CLI requests.
-n, --namespace string If present, the namespace scope for this CLI request
--request-timeout string The length of time to wait before giving up on a single server request. Non-zero values should contain a corresponding time unit (e.g. 1s, 2m, 3h). A value of zero means don't timeout requests. (default "0")
--as-user-extra stringArray User extras to impersonate for the operation, this flag can be repeated to specify multiple values for the same key.

@SaschaSchwarze0 SaschaSchwarze0 Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long time ago (#108), we put together a list of command line flags that we decided to hide from helps because we assessed them as edge cases and preferred those to not overwhelm our users so that they can focus on the flags we provide for our commands plus only a few common flags.

I consider --as-user-extra to also fall into the bucket of those that we should hide. Wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 requested changes
Copilot code review Copilot Copilot left review comments
@qu1queee qu1queee Awaiting requested review from qu1queee
@rxinui rxinui Awaiting requested review from rxinui

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

kind/dependency-change Categorizes issue or PR as related to changing dependencies release-note-none

Projects

Issues
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sayan-biswas @SaschaSchwarze0 @shipwright-ci-bot