Skip to content

TEST: Add e2e tests for shp buildrun gather#402

Merged
openshift-merge-bot[bot] merged 1 commit into
shipwright-io:mainfrom
kaizakin:adde2etests
Jun 29, 2026
Merged

TEST: Add e2e tests for shp buildrun gather#402
openshift-merge-bot[bot] merged 1 commit into
shipwright-io:mainfrom
kaizakin:adde2etests

Conversation

@kaizakin

@kaizakin kaizakin commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Changes

  • add e2e tests for shp buildrun gather

Related Issue

Fixes #401

Type of PR

/kind test
/kind feature

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Kind label has been set
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Copilot AI review requested due to automatic review settings June 25, 2026 20:51
@pull-request-size pull-request-size Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 25, 2026
@openshift-ci openshift-ci Bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 25, 2026
@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@kaizakin: The label(s) kind/test cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

  • add e2e tests for shp buildrun gather

Related Issue

Fixes #401

Type of PR

/kind test
/kind feature

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Kind label has been set
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot requested a review from hasanawad94 June 25, 2026 20:51
@openshift-ci openshift-ci Bot requested a review from HeavyWombat June 25, 2026 20:51
Copilot AI reviewed Jun 25, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an end-to-end Bats test to validate the shp buildrun gather workflow, ensuring BuildRun diagnostics can be collected into a directory and packaged as an archive.

Changes:

  • Introduces an e2e test that creates a Build + BuildRun and runs shp buildrun gather to validate gathered artifacts.
  • Verifies log collection under the gathered diagnostics directory.
  • Adds coverage for --archive output behavior (creates .tar.gz and removes the expanded directory).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/e2e/buildrun-gather.bats Outdated
Comment thread test/e2e/buildrun-gather.bats Outdated
@kaizakin kaizakin force-pushed the adde2etests branch 3 times, most recently from de34fd7 to dc7eb0a Compare June 28, 2026 11:21
@kaizakin
test: add e2e tests for shp buildrun gather
7bc8e93 
Signed-off-by: karthik balasubramanian <karthikbalasubramanian08@gmail.com>
@SaschaSchwarze0 SaschaSchwarze0 self-requested a review June 29, 2026 13:03
SaschaSchwarze0
SaschaSchwarze0 approved these changes Jun 29, 2026
View reviewed changes

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2026
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2026
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.20.0 milestone Jun 29, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 04686eb into shipwright-io:main Jun 29, 2026
10 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Issues Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes
@hasanawad94 hasanawad94 Awaiting requested review from hasanawad94
@HeavyWombat HeavyWombat Awaiting requested review from HeavyWombat

Assignees

@SaschaSchwarze0 SaschaSchwarze0

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Issues
Status: Done

Milestone

release-v0.20.0

Development

Successfully merging this pull request may close these issues.

Add e2e tests for shp buildrun gather

4 participants

@kaizakin @SaschaSchwarze0 @shipwright-ci-bot