feat: [SG-43419] Launch publisher via engine command with single_file_mode support#147
Open
chenm1adsk wants to merge 1 commit into
Open
Conversation
…_mode support
Replace direct app lookup + non-existent _set_context() call with the
established engine command callback pattern. Grab the publisher app from
the matched command's properties to call show_dialog() directly, passing
single_file_mode=True when the action is a Flow AM republish ("publish"),
so the dialog restricts users to dropping or browsing a single file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ticket/SG-43456_migration_1 #147 +/- ##
============================================================
Coverage 19.18% 19.18%
============================================================
Files 51 51
Lines 4842 4842
============================================================
Hits 929 929
Misses 3913 3913
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace direct app lookup + non-existent _set_context() call with the established engine command callback pattern.
Grab the publisher app from the matched command's properties to call show_dialog() directly, passing single_file_mode=True when the action is a Flow AM republish ("publish"), so the dialog restricts users to dropping or browsing a single file.
Tests
Verified when single_file_mode turned on, only accept one file in publish dialog
Also verified that this restriction doesn't cause regression when single_file_mode is off