Ported SelectorAdvanced.pm from GooCanvas2 to DrawingArea

[Photon89]

Since GooCanvas2 is archived and Debian seems to consider kicking Shutter out of testing, I started porting Shutter from GooCanvas2 to Gtk3::DrawingArea. I started with SelectorAdvanced.pm because it introduces the only hard dependency on GooCanvas2, the dependency in DrawingTool.pm is optional.

I need to admit that I heavily used AI to do the port. The functionality and the optics is identical to the old implementation (only the coordinates menu is now fixed at the bottom right rather than appearing next to the mouse pointer but this seems to be a restriction introduced by DrawingArea) but the code is put together from AI generated snippets, so I cannot guarantee high code quality.

But since all members of our team have only little time to spare for Shutters development, I figured that this is better than just leaving it with an outdated dependency for many months or years, till a proper rewrite is finished.

[DarthGandalf]

Briefly tested this: you cannot start selection on top of the help text

[DarthGandalf]

Using the right click window, I can move the selection past the screen size to the right

[DarthGandalf]

fixed at the bottom right rather than appearing next to the mouse pointer

on one hand, the previous behaviour was buggy when the click happened near the bottom right corner

on the other, this new behavior would break if there are several monitors arranged in a way that the bottom right corner is outside of any monitor?

[DarthGandalf]

another question: did you test it with hidpi?

[Photon89]

Thanks for the comments!

Briefly tested this: you cannot start selection on top of the help text

Using the right click window, I can move the selection past the screen size to the right

I'll try to get it fixed!

on the other, this new behavior would break if there are several monitors arranged in a way that the bottom right corner is outside of any monitor?

How can this happen?

another question: did you test it with hidpi?

Unfortunately, I currently own no hidpi screen. Maybe I should buy one for Shutter testing. 😄

[DarthGandalf]

Unfortunately, I currently own no hidpi screen

me neither. My only screen is non-hidpi. So I can't test all these things

How can this happen?

I cannot confirm that this is indeed what happens, since ^, but I think this may be the case if the screens are arranged e.g. like this:

[Photon89]

Please test again, I think, it should be fine now. The multi monitor issue is fixed because the dialog now appears at mouse pointer position which is for sure visible. Regarding hidpi, not tested still...