Skip to content

Wayland monitor capture, footer name/dir controls, editor UX - #827

Closed
underwaterdba wants to merge 0 commit into
shutter-project:masterfrom
underwaterdba:master
Closed

Wayland monitor capture, footer name/dir controls, editor UX#827
underwaterdba wants to merge 0 commit into
shutter-project:masterfrom
underwaterdba:master

Conversation

@underwaterdba

Copy link
Copy Markdown

Adding limited support for Wayland after Gnome 50 / Fedora 44 removed X11, also added some QoL changes to support my use of Shutter.

Wayland screenshots:

  • Add per-monitor capture on Wayland: the "Full" dropdown lists each monitor and crops the XDG portal's full-desktop capture to the chosen monitor (HiDPI-aware scaling).
  • Fix xdg_portal error handling: a "return" inside the eval block only exited the eval, so a non-zero/failed portal response returned undef and surfaced as the misleading "selection width or height is zero" error. It now returns a proper error code and message.
  • Wrap the Wayland capture in an object with capture/redo_capture/ get_history so full and per-monitor captures are repeatable via the redoshot (F5) shortcut; allow redoshot through the no-X11 guard.

Footer Name and Directory:

  • Add an editable Directory chooser and a per-shot Name box to the status bar. The Directory stays in sync with the profile/Preferences setting (via the file-set signal to avoid tree-model re-entrancy).
  • The Name box sets the $name wildcard (works on X11 and Wayland); a value like "sub/dir/name" creates the subdirectories under the profile directory (mkdir -p) and uses "name" as $name, keeping the Preferences filename pattern and auto-numbering.
  • Persist the Name box default with the profile settings.

Image editor:

  • Open the editor maximized by default.
  • Fit the whole image on the canvas by default (auto-fit until the user zooms manually).
  • Close the editor with the Esc key.

@DarthGandalf DarthGandalf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are several independent unrelated features bundled in the same PR/commit. This makes it hard to review, could you please split them?

@underwaterdba

underwaterdba commented Aug 14, 2026 via email

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants