Repository navigation
Synchronization - #22
Merged
Merged
Conversation
…m (fixes MPS crash) (#16130)
AMD+windows sets an unusually low maximum GPU virtual memory quota compared to other plaforms. For reference, the hardware limits on XT9060 are 128TB. On Nvidia RTX3060 it is 1TB. On nvidia RTX5090 it is 128TB. Bump this into the same league, but keep it to a modest 4TB pending further usage case need + testing going even higher to the hardware limits.
…#16188) * [Partner Nodes] feat(OpenRouter): add MAI-Image-2.6 image node Signed-off-by: Alexander Piskun <bigcat88@icloud.com> * [Partner Nodes] fix(api-client): show provider error details Signed-off-by: Alexander Piskun <bigcat88@icloud.com> --------- Signed-off-by: Alexander Piskun <bigcat88@icloud.com> Co-authored-by: Daxiong (Lin) <contact@comfyui-wiki.com>
…text node (#16195) Signed-off-by: Alexander Piskun <bigcat88@icloud.com> Co-authored-by: Purz <97489706+purzbeats@users.noreply.github.com>
…ment node and retire the dead widgets (#16201) * [Partner Nodes] feat(Tripo): migrate all nodes to the v3 API and add the Smart Segment node Signed-off-by: bigcat88 <bigcat88@icloud.com> * [Partner Nodes] feat(Tripo): deprecate Text to Model, Image to Model and Texture model in favour of V2 nodes without the retired widgets Signed-off-by: bigcat88 <bigcat88@icloud.com> * [Partner Nodes] fix(Tripo): report the mixamo retarget limitation for rigs whose v3 task echo carries no model version Signed-off-by: bigcat88 <bigcat88@icloud.com> * [Partner Nodes] fix(Tripo): keep the Smart Segment widgets inside the source options so the frontend can build the node Signed-off-by: bigcat88 <bigcat88@icloud.com> * [Partner Nodes] fix(Tripo): correct the Retarget and Smart Segment tooltips to what Tripo accepts Signed-off-by: bigcat88 <bigcat88@icloud.com> --------- Signed-off-by: bigcat88 <bigcat88@icloud.com>
…age node (#16229) Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
…utput would be empty (#16369) Signed-off-by: bigcat88 <bigcat88@icloud.com>
…alls and collect replays (#16220) * [Partner Nodes] feat(client): send Idempotency-Key on partner-proxy calls and collect replays Signed-off-by: Alexander Piskun <bigcat88@icloud.com> * [Partner Nodes] feat(client): opt partner nodes into Comfy-hosted asset URLs in place of inline media Signed-off-by: Alexander Piskun <bigcat88@icloud.com> --------- Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
The AR decode loop captured the per-layer graphs without decode buffers, so Llama2_ fell back to x = x.clone() and every replay read the address of the first step after it had been freed. The output was garbage audio codes with no error: the decoded track is NaN, saved as a constant -32768 by the FLAC encoder. YuE2 and the generic generate() already pin the hidden state and rotary tensors through decode_buffers; do the same here, gated the way generate() gates it. Fixes #16002 (the silent-noise report) and #16222.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.