Fix after_call not invoked for unknown tool names - #1535
Open
ikatyal2110 wants to merge 1 commit into
Open
Conversation
When the model names a tool that does not exist, the ToolResult error was appended and execution continued without firing the after_call callback. This meant --td/--tools-debug produced no output for unrecognised tool calls. Both the sync and async execution paths now call after_call before continuing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tool response references a tool name not in the registered tools list, the
after_callcallback was silently skipped in both the sync and async code paths, preventing callers from observing or cleaning up after the call. This fixes both paths to always invokeafter_callregardless of whether the tool name is recognized. Fixes #1151Generated by Claude Code