fix(app): resume auto-approve after IME composition - #88
Merged
Merged
Conversation
Keep recognized prompts tracked during IME composition so static dialogs resume detection after composition ends without new PTY output. Add regression coverage for the agy log-search layout and IME recovery. Keep the original reported stall documented as unresolved. Validation: cargo test -p noa-app (1239 passed, 6 ignored).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recognized approval dialog arriving during IME composition could lose its rescan deadline and remain pending after composition ended. Keep the dialog tracked while approval is suppressed, then require two unsuppressed stable scans before sending Enter. Detection now resumes even when ending composition produces no PTY output.
Add regression coverage for IME recovery, duplicate suppression, and the agy log-search dialog through both text and VT/grid detection. Update the auto-approve specification with the behavior and investigation follow-up.
Validation:
cargo test --workspace— 2659 passed, 15 ignored, 0 failed.cargo fmt --all -- --checkgit diff --check origin/main...HEADThe originally reported agy stall remains unconfirmed: auto-approve was enabled before the dialog appeared, but the composition state at that time is unknown. The follow-up in
docs/specs/auto-approve-mode.mdcalls for inspecting[auto-approve]diagnostics withNOA_AUTO_APPROVE_TRACE=1on recurrence. Acceptance by a running CLI has not been verified for this change.